components/subresource_filter/core/common/unindexed_ruleset_unittest.cc - Issue 2793993002: [subresource_filter] Replace KMP by std::search.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/core/common/unindexed_ruleset_unittest.cc

Issue 2793993002: [subresource_filter] Replace KMP by std::search. (Closed)

Patch Set: Fix DCHECK. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/core/common/test_ruleset_utils.h ('k') | components/subresource_filter/core/common/url_pattern.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/core/common/unindexed_ruleset_unittest.cc

diff --git a/components/subresource_filter/core/common/unindexed_ruleset_unittest.cc b/components/subresource_filter/core/common/unindexed_ruleset_unittest.cc

index 812d1b9ea097c9c1a9c30a9164c14e69cb53d0a2..bc66bbe13a46aac44f730cf699840256ca7c0f5d 100644

--- a/components/subresource_filter/core/common/unindexed_ruleset_unittest.cc

+++ b/components/subresource_filter/core/common/unindexed_ruleset_unittest.cc

@@ -44,11 +44,11 @@ proto::UrlRule CreateRule(const UrlPattern& url_pattern,

rule.set_source_type(source_type);

rule.set_element_types(proto::ELEMENT_TYPE_ALL);

- rule.set_url_pattern_type(url_pattern.type);

- rule.set_anchor_left(url_pattern.anchor_left);

- rule.set_anchor_right(url_pattern.anchor_right);

- rule.set_match_case(url_pattern.match_case);

- rule.set_url_pattern(url_pattern.url_pattern.as_string());

+ rule.set_url_pattern_type(url_pattern.type());

+ rule.set_anchor_left(url_pattern.anchor_left());

+ rule.set_anchor_right(url_pattern.anchor_right());

+ rule.set_match_case(url_pattern.match_case());

+ rule.set_url_pattern(url_pattern.url_pattern().as_string());

return rule;

}