Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: components/subresource_filter/core/common/indexed_ruleset_unittest.cc

Issue 2793993002: [subresource_filter] Replace KMP by std::search. (Closed)
Patch Set: Fix DCHECK. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/core/common/indexed_ruleset_unittest.cc
diff --git a/components/subresource_filter/core/common/indexed_ruleset_unittest.cc b/components/subresource_filter/core/common/indexed_ruleset_unittest.cc
index e57181fce9ce5fb800a45cbdaf68aaaabb6dbbfa..a837f93f38bd892fcef11c912879c48b5d463d40 100644
--- a/components/subresource_filter/core/common/indexed_ruleset_unittest.cc
+++ b/components/subresource_filter/core/common/indexed_ruleset_unittest.cc
@@ -48,11 +48,11 @@ class UrlRuleBuilder {
rule_.set_source_type(source_type);
rule_.set_element_types(proto::ELEMENT_TYPE_ALL);
- rule_.set_url_pattern_type(url_pattern.type);
- rule_.set_anchor_left(url_pattern.anchor_left);
- rule_.set_anchor_right(url_pattern.anchor_right);
- rule_.set_match_case(url_pattern.match_case);
- rule_.set_url_pattern(url_pattern.url_pattern.as_string());
+ rule_.set_url_pattern_type(url_pattern.type());
+ rule_.set_anchor_left(url_pattern.anchor_left());
+ rule_.set_anchor_right(url_pattern.anchor_right());
+ rule_.set_match_case(url_pattern.match_case());
+ rule_.set_url_pattern(url_pattern.url_pattern().as_string());
}
UrlRuleBuilder& AddDomain(std::string domain_pattern) {
@@ -291,9 +291,8 @@ TEST_F(IndexedRulesetTest, OneRuleWithoutMetaInfo) {
};
for (const auto& test_case : kTestCases) {
- SCOPED_TRACE(testing::Message()
- << "Rule: " << test_case.url_pattern.url_pattern
- << "; URL: " << test_case.url);
+ SCOPED_TRACE(testing::Message() << "Rule: " << test_case.url_pattern
+ << "; URL: " << test_case.url);
AddBlacklistRule(test_case.url_pattern);
Finish();

Powered by Google App Engine
This is Rietveld 408576698