[subresource_filter] Replace KMP by std::search.

components/subresource_filter/core/common/test_ruleset_creator.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SUBRESOURCE_FILTER_CORE_COMMON_TEST_RULESET_CREATOR_H_
 #define COMPONENTS_SUBRESOURCE_FILTER_CORE_COMMON_TEST_RULESET_CREATOR_H_
 
 #include <stdint.h>
 
 #include <vector>
@@ skipping 67 matching lines @@
   // Similar to CreateRulesetToDisallowURLsWithPathSuffix, but the resulting
   // ruleset consists of |num_of_suffixes| rules, each of them disallowing URLs
   // with suffixes of the form |suffix|_k, 0 <= k < |num_of_suffixes|.
   void CreateRulesetToDisallowURLsWithManySuffixes(
       base::StringPiece suffix,
       int num_of_suffixes,
       TestRulesetPair* test_ruleset_pair);
 
   void CreateRulesetWithRules(const std::vector<proto::UrlRule>& rules,
                               TestRulesetPair* test_ruleset_pair);
+  void CreateRulesetWithRules(const std::vector<proto::UrlRule>& rules,

[engedy, 2017/04/05 10:55:10]

nit: CreateUnindexedRulesetWithRulest for consistency, and to avoid overloading.

[pkalinnikov, 2017/04/05 13:29:21]

Done.

+                              TestRuleset* test_unindexed_ruleset);
 
   // Returns a unique |path| that is valid for the lifetime of this instance.
   // No file at |path| will be automatically created.
   void GetUniqueTemporaryPath(base::FilePath* path);
 
  private:
   // Writes the |ruleset_contents| to a temporary file, and initializes
   // |ruleset| to have the same |contents|, and the |path| to this file.
   void CreateTestRulesetFromContents(std::vector<uint8_t> ruleset_contents,
                                      TestRuleset* ruleset);
 
   base::ScopedTempDir scoped_temp_dir_;
   int next_unique_file_suffix = 1;
 
   DISALLOW_COPY_AND_ASSIGN(TestRulesetCreator);
 };
 
 }  // namespace testing
 }  // namespace subresource_filter
 
 #endif  // COMPONENTS_SUBRESOURCE_FILTER_CORE_COMMON_TEST_RULESET_CREATOR_H_