Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObject.cpp

Issue 2793913007: Switch to equalIgnoringASCIICase throughout modules/accessibility (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXObject.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
index 569da4bc66fdf9193cec78cbdd199304585cf8e4..3e18e556d466beaf250314eaee1346ca0c2f1955 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
@@ -596,7 +596,7 @@ AXObject* AXObject::leafNodeAncestor() const {
const AXObject* AXObject::ariaHiddenRoot() const {
for (const AXObject* object = this; object; object = object->parentObject()) {
- if (equalIgnoringCase(object->getAttribute(aria_hiddenAttr), "true"))
+ if (equalIgnoringASCIICase(object->getAttribute(aria_hiddenAttr), "true"))
return object;
}
@@ -610,9 +610,9 @@ bool AXObject::isDescendantOfDisabledNode() const {
const AXObject* AXObject::disabledAncestor() const {
const AtomicString& disabled = getAttribute(aria_disabledAttr);
- if (equalIgnoringCase(disabled, "true"))
+ if (equalIgnoringASCIICase(disabled, "true"))
return this;
- if (equalIgnoringCase(disabled, "false"))
+ if (equalIgnoringASCIICase(disabled, "false"))
return 0;
if (AXObject* parent = parentObject())
@@ -723,7 +723,7 @@ String AXObject::recursiveTextAlternative(const AXObject& axObj,
}
bool AXObject::isHiddenForTextAlternativeCalculation() const {
- if (equalIgnoringCase(getAttribute(aria_hiddenAttr), "false"))
+ if (equalIgnoringASCIICase(getAttribute(aria_hiddenAttr), "false"))
return false;
if (getLayoutObject())
@@ -955,10 +955,10 @@ AXSupportedAction AXObject::action() const {
AccessibilityButtonState AXObject::checkboxOrRadioValue() const {
const AtomicString& checkedAttribute =
getAOMPropertyOrARIAAttribute(AOMStringProperty::kChecked);
- if (equalIgnoringCase(checkedAttribute, "true"))
+ if (equalIgnoringASCIICase(checkedAttribute, "true"))
return ButtonStateOn;
- if (equalIgnoringCase(checkedAttribute, "mixed")) {
+ if (equalIgnoringASCIICase(checkedAttribute, "mixed")) {
// Only checkboxes should support the mixed state.
AccessibilityRole role = ariaRoleAttribute();
if (role == CheckBoxRole || role == MenuItemCheckBoxRole)
@@ -982,7 +982,7 @@ bool AXObject::isMultiline() const {
if (!isNativeTextControl() && !isNonNativeTextControl())
return false;
- return equalIgnoringCase(getAttribute(aria_multilineAttr), "true");
+ return equalIgnoringASCIICase(getAttribute(aria_multilineAttr), "true");
}
bool AXObject::ariaPressedIsPresent() const {
@@ -1063,8 +1063,8 @@ int AXObject::indexInParent() const {
bool AXObject::isLiveRegion() const {
const AtomicString& liveRegion = liveRegionStatus();
- return equalIgnoringCase(liveRegion, "polite") ||
- equalIgnoringCase(liveRegion, "assertive");
+ return equalIgnoringASCIICase(liveRegion, "polite") ||
+ equalIgnoringASCIICase(liveRegion, "assertive");
}
AXObject* AXObject::liveRegionRoot() const {

Powered by Google App Engine
This is Rietveld 408576698