Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Unified Diff: net/tools/transport_security_state_generator/spki_hash.h

Issue 2793823002: Add unittests for certificate and file parsing. (Closed)
Patch Set: comments davidben Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/tools/transport_security_state_generator/spki_hash.h
diff --git a/net/tools/transport_security_state_generator/spki_hash.h b/net/tools/transport_security_state_generator/spki_hash.h
index c65313cece1fb286f114bbb1b0d5139fff057a44..20de8fecc8a87985c2c86dee5e961391164b1748 100644
--- a/net/tools/transport_security_state_generator/spki_hash.h
+++ b/net/tools/transport_security_state_generator/spki_hash.h
@@ -9,6 +9,8 @@
#include <string>
#include <vector>
+#include "base/strings/string_piece.h"
+
namespace net {
namespace transport_security_state {
@@ -24,7 +26,7 @@ class SPKIHash {
// SPKI hashes are SHA256. Other algorithms are not supported. Returns true
// on success and copies the decoded bytes to |data_|. Returns false on
// failure.
- bool FromString(const std::string& hash_string);
+ bool FromString(base::StringPiece hash_string);
// Calculates the SHA256 digest over |*input| and copies the result to
// |data_|.

Powered by Google App Engine
This is Rietveld 408576698