Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: base/allocator/BUILD.gn

Issue 2793793002: Fix -Wshift-negative-value transgression in tcmalloc. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/allocator/BUILD.gn
diff --git a/base/allocator/BUILD.gn b/base/allocator/BUILD.gn
index 2f58375c5a296da0bf557e31024a9709425e1174..ac534817fc8eb4252bbb2bfee5babd1bcd262e45 100644
--- a/base/allocator/BUILD.gn
+++ b/base/allocator/BUILD.gn
@@ -65,17 +65,11 @@ config("tcmalloc_flags") {
# tcmalloc contains some unused local template specializations.
"-Wno-unused-function",
- # tcmalloc uses COMPILE_ASSERT without static_assert but with
- # typedefs.
+ # tcmalloc uses COMPILE_ASSERT without static_assert but with typedefs.
"-Wno-unused-local-typedefs",
- # for magic2_ in debugallocation.cc (only built in Debug builds)
- # typedefs.
+ # for magic2_ in debugallocation.cc (only built in Debug builds) typedefs.
"-Wno-unused-private-field",
-
- # base/basictypes.h's kint64min definition shifts a negative value around,
- # which is undefined behavior. TODO(thakis): Try to get that fixed.
- "-Wno-shift-negative-value",
]
} else {
cflags = []
« no previous file with comments | « no previous file | third_party/tcmalloc/README.chromium » ('j') | third_party/tcmalloc/chromium/src/base/basictypes.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698