Remove some legacy software WebWidgetClient callbacks from RenderWidget

Remove some legacy software WebWidgetClient callbacks from RenderWidget

The callbacks are overridden by WebTestProxy in layout tests, and layout tests should be the only times that they're called, so they're not useful anymore.

BUG=362164
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269975

[piman, 2014-05-12 23:55:21]

https://codereview.chromium.org/279373002/diff/1/content/renderer/render_widg...
File content/renderer/render_widget.cc (left):

https://codereview.chromium.org/279373002/diff/1/content/renderer/render_widg...
content/renderer/render_widget.cc:1161: void
RenderWidget::didInvalidateRect(const WebRect& rect) {
There are still paths in WebKit that call didInvalidateRect/didScrollRect. In
particular for popups.

Now, I think they shouldn't, but I'm not sure we can blindly remove these?
Or do we know that they're redundant with the compositor-based mechanisms?

[jbauman, 2014-05-13 00:01:10]

On 2014/05/12 23:55:21, piman wrote:
>
https://codereview.chromium.org/279373002/diff/1/content/renderer/render_widg...
> File content/renderer/render_widget.cc (left):
> 
>
https://codereview.chromium.org/279373002/diff/1/content/renderer/render_widg...
> content/renderer/render_widget.cc:1161: void
> RenderWidget::didInvalidateRect(const WebRect& rect) {
> There are still paths in WebKit that call didInvalidateRect/didScrollRect. In
> particular for popups.
> 
> Now, I think they shouldn't, but I'm not sure we can blindly remove these?
> Or do we know that they're redundant with the compositor-based mechanisms?

Yeah, they're redundant. They can't be that useful in any case because
InvalidationCallback only flushes pending input (done by the compositor anyway),
not anything related to drawing.

[piman, 2014-05-13 00:08:01]

OK, LGTM then.

[jbauman, 2014-05-13 00:11:14]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2014-05-13 00:12:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbauman@chromium.org/279373002/1

[commit-bot: I haz the power, 2014-05-13 02:47:24]

Change committed as 269975