Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1417)

Issue 2793603002: Nicer message when attempting to use Observatory from dart_bootstrap, dart_precompiled_runtime or a… (Closed)

Created:
3 years, 8 months ago by rmacnak
Modified:
3 years, 8 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org, mfairhurst
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Nicer message when attempting to use Observatory from dart_bootstrap, dart_precompiled_runtime or an unnamed badly configured build. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/d0529c86380fc98ba5b93feca15ad4c4b935663f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M runtime/bin/vmservice/server.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/lib/vmservice_patch.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 8 months ago (2017-03-31 18:14:47 UTC) #2
Cutch
lgtm
3 years, 8 months ago (2017-03-31 20:19:15 UTC) #3
rmacnak
3 years, 8 months ago (2017-03-31 20:29:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d0529c86380fc98ba5b93feca15ad4c4b935663f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698