MD Settings: Restore focus after closing various dialogs.

chrome/browser/resources/settings/people_page/people_page.js

Index: chrome/browser/resources/settings/people_page/people_page.js
diff --git a/chrome/browser/resources/settings/people_page/people_page.js b/chrome/browser/resources/settings/people_page/people_page.js
index f548fff5ae9b22356b8a40c5810eef13c9d963d6..79aab13bc16cc58b5373029da956d995e8fa679a 100644
--- a/chrome/browser/resources/settings/people_page/people_page.js
+++ b/chrome/browser/resources/settings/people_page/people_page.js
@@ -308,6 +308,8 @@ Polymer({
   /** @private */
   onDisconnectClosed_: function() {
     this.showDisconnectDialog_ = false;
+    this.$$('#disconnectButton').focus();

[tommycli, 2017/04/03 15:39:50]

Hmm... this is interesting to me. Usually after a successful signout, the
disconnect dialog is no longer shown. Perhaps we should focus the sign-in dialog
instead.

[dpapad, 2017/04/03 19:23:05]

I thought about this and settled to the current approach with the following
rationale:

The main goal of this patch is to ensure that focus is not completely lost when
the dialog is closed (without this CL it goes to the browser's home button next
to the omnibox). Focusing the "sign out" button even though it is being dom-ifed
out shortly after, achieves the goal of rescuing the focus. Even though the
"sign in" button is not focused, when the user presses Tab the focus goes to the
next element, which is the "learn more" link. Given that the "sign in" button is
added to the DOM after a series of async operations, so it is not trivial to get
a reference to it, I would prefer to addressing this case separately (but I
don't think it should be a blocker). WDYT?

[tommycli, 2017/04/03 19:30:51]

I'm fine with addressing it separately. And yeah, it shouldn't block this.

+
     if (settings.getCurrentRoute() == settings.Route.SIGN_OUT)
       settings.navigateToPreviousRoute();
     this.fire('signout-dialog-closed');
@@ -437,6 +439,7 @@ Polymer({
   /** @private */
   onImportDataDialogClosed_: function() {
     settings.navigateToPreviousRoute();
+    this.$.importDataDialogTrigger.focus();
   },
 // </if>