Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5567)

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 2793443003: Removed NOTIFICATION_BROWSER_CLOSING notification (Closed)
Patch Set: Reset g_shutdown_type on close cancel Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_commands.cc
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc
index efcc39cc4d372d674a7f6f303bf3f5334abefc80..2ae9d8f28c2b5c06e4755251ee9a965c950560a0 100644
--- a/chrome/browser/ui/browser_commands.cc
+++ b/chrome/browser/ui/browser_commands.cc
@@ -11,6 +11,7 @@
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/browser_process.h"
+#include "chrome/browser/browser_shutdown.h"
#include "chrome/browser/browsing_data/browsing_data_helper.h"
#include "chrome/browser/browsing_data/browsing_data_remover.h"
#include "chrome/browser/browsing_data/browsing_data_remover_factory.h"
@@ -756,6 +757,10 @@ void ConvertPopupToTabbedBrowser(Browser* browser) {
void Exit() {
content::RecordAction(UserMetricsAction("Exit"));
+// On Mac, the platform-specific part handles setting this.
+#if !defined(OS_MACOSX)
+ browser_shutdown::SetTryingToQuit(true);
Alexey Seren 2017/04/09 17:51:37 By comments for SetTryingToQuit function we should
hashimoto 2017/04/14 08:54:37 IIUC the comment discourages to call SetTryingToQu
+#endif
chrome::AttemptUserExit();
}

Powered by Google App Engine
This is Rietveld 408576698