chrome/browser/ui/browser.cc - Issue 2793443003: Removed NOTIFICATION_BROWSER_CLOSING notification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 2793443003: Removed NOTIFICATION_BROWSER_CLOSING notification (Closed)

Patch Set: Update CL basing on review comments (rebase) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index 7d0394fb25122655036b902a6fb8270ebfe87b07..ac29b0c21dcac42b18eb2e9ba3fab75c790b7ddd 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -751,11 +751,7 @@ void Browser::OnWindowClosing() {

if (tab_restore_service && is_type_tabbed() && tab_strip_model_->count())

tab_restore_service->BrowserClosing(live_tab_context());

- // TODO(sky): convert session/tab restore to use notification.

- content::NotificationService::current()->Notify(

- chrome::NOTIFICATION_BROWSER_CLOSING,

- content::Source<Browser>(this),

- content::NotificationService::NoDetails());

+ BrowserList::NotifyBrowserCloseStarted(this);

if (!IsFastTabUnloadEnabled())

tab_strip_model_->CloseAllTabs();