Removed NOTIFICATION_BROWSER_CLOSING notification

chrome/browser/browser_shutdown.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_shutdown.h"
 
 #include <stdint.h>
 
 #include <map>
 #include <memory>
@@ skipping 334 matching lines @@
       BrowserThread::FILE, FROM_HERE,
       base::Bind(&ReadLastShutdownFile, type, num_procs, num_procs_slow));
 }
 
 void SetTryingToQuit(bool quitting) {
   g_trying_to_quit = quitting;
 
   if (quitting)
     return;
 
+  g_shutdown_type = NOT_VALID;

[Alexey Seren, 2017/04/09 17:51:37]

reset shutdown state on browser close cancel

[hashimoto, 2017/04/14 08:54:37]

I'm not sure if it's safe to allow cancelling shutdown after calling
OnShutdownStarting().
OnShutdownStarting() also performs things other than setting g_shutdown_type.

Shouldn't we call OnShutdownStarting() after we finally decide to do shutdown?

[Alexey Seren, 2017/04/22 19:52:54]

You are right. It is not safe.
This CL https://codereview.chromium.org/2695233003 makes some fixes in unload
controller. So now OnWindowClosing is called only when all unload events are
finished and we cannot cancel browser closing at this moment.
So now I can remove code related to cancel processing.

+
   // Reset the restart-related preferences. They get set unconditionally through
   // calls such as chrome::AttemptRestart(), and need to be reset if the restart
   // attempt is cancelled.
   PrefService* pref_service = g_browser_process->local_state();
   if (pref_service) {
 #if !defined(OS_ANDROID)
     pref_service->ClearPref(prefs::kWasRestarted);
 #endif  // !defined(OS_ANDROID)
     pref_service->ClearPref(prefs::kRestartLastSessionOnShutdown);
   }
@@ skipping 14 matching lines @@
     base::trace_event::TraceConfig trace_config(
         command_line.GetSwitchValueASCII(switches::kTraceShutdown), "");
     content::TracingController::GetInstance()->StartTracing(
         trace_config,
         content::TracingController::StartTracingDoneCallback());
   }
   TRACE_EVENT0("shutdown", "StartShutdownTracing");
 }
 
 }  // namespace browser_shutdown