Removed NOTIFICATION_BROWSER_CLOSING notification

chrome/browser/ui/browser_list.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_list.h"
 
 #include <algorithm>
 
 #include "base/auto_reset.h"
 #include "base/logging.h"
@@ skipping 65 matching lines @@
 
   for (chrome::BrowserListObserver& observer : observers_.Get())
     observer.OnBrowserAdded(browser);
 }
 
 // static
 void BrowserList::RemoveBrowser(Browser* browser) {
   // Remove |browser| from the appropriate list instance.
   BrowserList* browser_list = GetInstance();
   RemoveBrowserFrom(browser, &browser_list->last_active_browsers_);
+  RemoveBrowserFrom(browser, &browser_list->currently_closing_browsers_);
 
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_BROWSER_CLOSED,

[sky, 2017/03/31 14:23:41]

And remove this notification too?

[Alexey Seren, 2017/04/02 12:02:35]

As like as NOTIFICATION_BROWSER_CLOSE_CANCELLED, this notification is used in
several places in chrome. I think it is better to do it in separate task.

       content::Source<Browser>(browser),
       content::NotificationService::NoDetails());
 
   RemoveBrowserFrom(browser, &browser_list->browsers_);
 
   for (chrome::BrowserListObserver& observer : observers_.Get())
     observer.OnBrowserRemoved(browser);
 
   browser->UnregisterKeepAlive();
 
@@ skipping 143 matching lines @@
     observer.OnBrowserSetLastActive(browser);
 }
 
 // static
 void BrowserList::NotifyBrowserNoLongerActive(Browser* browser) {
   for (chrome::BrowserListObserver& observer : observers_.Get())
     observer.OnBrowserNoLongerActive(browser);
 }
 
 // static
+void BrowserList::NotifyBrowserWindowClosing(Browser* browser) {
+  BrowserVector* currently_closing_browsers =
+      &GetInstance()->currently_closing_browsers_;
+  RemoveBrowserFrom(browser, currently_closing_browsers);
+  currently_closing_browsers->push_back(browser);
+
+  for (chrome::BrowserListObserver& observer : observers_.Get())
+    observer.OnBrowserWindowClosing(browser);
+}
+
+// static
+void BrowserList::NotifyBrowserCloseCancelled(Browser* browser) {
+  RemoveBrowserFrom(browser, &GetInstance()->currently_closing_browsers_);
+
+  for (chrome::BrowserListObserver& observer : observers_.Get())
+    observer.OnBrowserCloseCancelled(browser);
+}
+
+// static
 bool BrowserList::IsIncognitoSessionActive() {
   for (auto* browser : *BrowserList::GetInstance()) {
     if (browser->profile()->IsOffTheRecord())
       return true;
   }
   return false;
 }
 
 // static
 bool BrowserList::IsIncognitoSessionActiveForProfile(Profile* profile) {
@@ skipping 16 matching lines @@
 }
 
 // static
 void BrowserList::RemoveBrowserFrom(Browser* browser,
                                     BrowserVector* browser_list) {
   BrowserVector::iterator remove_browser =
       std::find(browser_list->begin(), browser_list->end(), browser);
   if (remove_browser != browser_list->end())
     browser_list->erase(remove_browser);
 }