Removed NOTIFICATION_BROWSER_CLOSING notification

chrome/browser/ui/browser.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <string>
@@ skipping 728 matching lines @@
       TabRestoreServiceFactory::GetForProfile(profile());
 
 #if defined(USE_AURA)
   if (tab_restore_service && is_app() && !is_devtools())
     tab_restore_service->BrowserClosing(live_tab_context());
 #endif
 
   if (tab_restore_service && is_type_tabbed() && tab_strip_model_->count())
     tab_restore_service->BrowserClosing(live_tab_context());
 
+  BrowserList::NotifyBrowserWindowClosing(this);
+
   // TODO(sky): convert session/tab restore to use notification.
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_BROWSER_CLOSING,
       content::Source<Browser>(this),
       content::NotificationService::NoDetails());
 
   if (!IsFastTabUnloadEnabled())
     tab_strip_model_->CloseAllTabs();
 }
 
@@ skipping 1790 matching lines @@
       BookmarkBar::DONT_ANIMATE_STATE_CHANGE);
 }
 
 bool Browser::ShouldHideUIForFullscreen() const {
   // Windows and GTK remove the browser controls in fullscreen, but Mac and Ash
   // keep the controls in a slide-down panel.
   return window_ && window_->ShouldHideUIForFullscreen();
 }
 
 bool Browser::ShouldStartShutdown() const {
-  return BrowserList::GetInstance()->size() <= 1;
+  DCHECK_GE(BrowserList::GetInstance()->size(),
+            BrowserList::GetInstance()->currently_closing_browsers_count());
+  return (BrowserList::GetInstance()->size() -
+          BrowserList::GetInstance()->currently_closing_browsers_count()) <= 1;

[sky, 2017/03/31 14:23:41]

Why do you need the <= 1? Shouldn't it be size() + 1 ==
currently_closing_browsers_count(), with a description as to why the + 1?

[Alexey Seren, 2017/04/02 12:02:35]

Yes you are right. Equality checking will allow to start shutdown process only
once (because Browser::OnWindowClosing is called several times).

Hope this comment will be clear:
// Start shutdown process only when closing the last window.

 }
 
 bool Browser::MaybeCreateBackgroundContents(
     content::SiteInstance* source_site_instance,
     const GURL& opener_url,
     int32_t route_id,
     int32_t main_frame_route_id,
     int32_t main_frame_widget_route_id,
     const std::string& frame_name,
     const GURL& target_url,
@@ skipping 68 matching lines @@
     // new window later, thus we need to navigate the window now.
     if (contents) {
       contents->web_contents()->GetController().LoadURL(
           target_url, content::Referrer(), ui::PAGE_TRANSITION_LINK,
           std::string());  // No extra headers.
     }
   }
 
   return contents != NULL;
 }