Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Side by Side Diff: chrome/browser/ui/content_settings/content_setting_bubble_model.cc

Issue 2793413002: [subresource_filter] Update the desktop UI according to mocks (Closed)
Patch Set: ordering Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/content_settings/content_setting_bubble_model.h" 5 #include "chrome/browser/ui/content_settings/content_setting_bubble_model.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/feature_list.h" 10 #include "base/feature_list.h"
(...skipping 1229 matching lines...) Expand 10 before | Expand all | Expand 10 after
1240 ~ContentSettingSubresourceFilterBubbleModel() {} 1240 ~ContentSettingSubresourceFilterBubbleModel() {}
1241 1241
1242 void ContentSettingSubresourceFilterBubbleModel::SetTitle() { 1242 void ContentSettingSubresourceFilterBubbleModel::SetTitle() {
1243 set_title( 1243 set_title(
1244 l10n_util::GetStringUTF16(IDS_FILTERED_DECEPTIVE_CONTENT_PROMPT_TITLE)); 1244 l10n_util::GetStringUTF16(IDS_FILTERED_DECEPTIVE_CONTENT_PROMPT_TITLE));
1245 } 1245 }
1246 1246
1247 void ContentSettingSubresourceFilterBubbleModel::SetManageText() { 1247 void ContentSettingSubresourceFilterBubbleModel::SetManageText() {
1248 set_manage_text( 1248 set_manage_text(
1249 l10n_util::GetStringUTF8(IDS_FILTERED_DECEPTIVE_CONTENT_PROMPT_RELOAD)); 1249 l10n_util::GetStringUTF8(IDS_FILTERED_DECEPTIVE_CONTENT_PROMPT_RELOAD));
1250 set_show_manage_text_as_button(true); 1250 set_show_manage_text_as_checkbox(true);
1251 } 1251 }
1252 1252
1253 void ContentSettingSubresourceFilterBubbleModel::SetMessage() { 1253 void ContentSettingSubresourceFilterBubbleModel::SetMessage() {
1254 set_message(l10n_util::GetStringUTF16( 1254 set_message(l10n_util::GetStringUTF16(
1255 IDS_FILTERED_DECEPTIVE_CONTENT_PROMPT_EXPLANATION)); 1255 IDS_FILTERED_DECEPTIVE_CONTENT_PROMPT_EXPLANATION));
1256 } 1256 }
1257 1257
1258 void ContentSettingSubresourceFilterBubbleModel::OnManageLinkClicked() { 1258 void ContentSettingSubresourceFilterBubbleModel::OnManageCheckboxChecked(
1259 subresource_filter::ContentSubresourceFilterDriverFactory* driver_factory = 1259 bool is_checked) {
1260 subresource_filter::ContentSubresourceFilterDriverFactory:: 1260 int string_id = is_checked ? IDS_APP_MENU_RELOAD : IDS_DONE;
1261 FromWebContents(web_contents()); 1261 set_done_button_text(l10n_util::GetStringUTF16(string_id));
engedy 2017/04/06 14:02:59 nit: Have you considered setting this to the empty
Charlie Harrison 2017/04/06 14:46:55 Good idea, let me do that.
1262 driver_factory->OnReloadRequested(); 1262 is_checked_ = is_checked;
1263 }
1264
1265 void ContentSettingSubresourceFilterBubbleModel::OnDoneClicked() {
1266 if (is_checked_) {
1267 subresource_filter::ContentSubresourceFilterDriverFactory* driver_factory =
1268 subresource_filter::ContentSubresourceFilterDriverFactory::
1269 FromWebContents(web_contents());
1270 driver_factory->OnReloadRequested();
1271 }
1263 } 1272 }
1264 1273
1265 ContentSettingSubresourceFilterBubbleModel* 1274 ContentSettingSubresourceFilterBubbleModel*
1266 ContentSettingSubresourceFilterBubbleModel::AsSubresourceFilterBubbleModel() { 1275 ContentSettingSubresourceFilterBubbleModel::AsSubresourceFilterBubbleModel() {
1267 return this; 1276 return this;
1268 } 1277 }
1269 1278
1270 // ContentSettingMidiSysExBubbleModel ------------------------------------------ 1279 // ContentSettingMidiSysExBubbleModel ------------------------------------------
1271 1280
1272 class ContentSettingMidiSysExBubbleModel 1281 class ContentSettingMidiSysExBubbleModel
(...skipping 274 matching lines...) Expand 10 before | Expand all | Expand 10 after
1547 1556
1548 ContentSettingBubbleModel::DomainList::~DomainList() {} 1557 ContentSettingBubbleModel::DomainList::~DomainList() {}
1549 1558
1550 ContentSettingBubbleModel::MediaMenu::MediaMenu() : disabled(false) {} 1559 ContentSettingBubbleModel::MediaMenu::MediaMenu() : disabled(false) {}
1551 1560
1552 ContentSettingBubbleModel::MediaMenu::MediaMenu(const MediaMenu& other) = 1561 ContentSettingBubbleModel::MediaMenu::MediaMenu(const MediaMenu& other) =
1553 default; 1562 default;
1554 1563
1555 ContentSettingBubbleModel::MediaMenu::~MediaMenu() {} 1564 ContentSettingBubbleModel::MediaMenu::~MediaMenu() {}
1556 1565
1557 ContentSettingBubbleModel::BubbleContent::BubbleContent() 1566 ContentSettingBubbleModel::BubbleContent::BubbleContent() {}
1558 : radio_group_enabled(false),
1559 custom_link_enabled(false),
1560 show_manage_text_as_button(false) {}
1561 1567
1562 ContentSettingBubbleModel::BubbleContent::~BubbleContent() {} 1568 ContentSettingBubbleModel::BubbleContent::~BubbleContent() {}
1563 1569
1564 void ContentSettingBubbleModel::Observe( 1570 void ContentSettingBubbleModel::Observe(
1565 int type, 1571 int type,
1566 const content::NotificationSource& source, 1572 const content::NotificationSource& source,
1567 const content::NotificationDetails& details) { 1573 const content::NotificationDetails& details) {
1568 if (type == content::NOTIFICATION_WEB_CONTENTS_DESTROYED) { 1574 if (type == content::NOTIFICATION_WEB_CONTENTS_DESTROYED) {
1569 DCHECK_EQ(web_contents_, 1575 DCHECK_EQ(web_contents_,
1570 content::Source<WebContents>(source).ptr()); 1576 content::Source<WebContents>(source).ptr());
(...skipping 19 matching lines...) Expand all
1590 1596
1591 ContentSettingSubresourceFilterBubbleModel* 1597 ContentSettingSubresourceFilterBubbleModel*
1592 ContentSettingBubbleModel::AsSubresourceFilterBubbleModel() { 1598 ContentSettingBubbleModel::AsSubresourceFilterBubbleModel() {
1593 return nullptr; 1599 return nullptr;
1594 } 1600 }
1595 1601
1596 ContentSettingDownloadsBubbleModel* 1602 ContentSettingDownloadsBubbleModel*
1597 ContentSettingBubbleModel::AsDownloadsBubbleModel() { 1603 ContentSettingBubbleModel::AsDownloadsBubbleModel() {
1598 return nullptr; 1604 return nullptr;
1599 } 1605 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698