[subresource_filter] Update the desktop UI according to mocks

chrome/browser/ui/content_settings/content_setting_bubble_model.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/content_settings/content_setting_bubble_model.h"
 
 #include <stddef.h>
 
 #include "base/command_line.h"
 #include "base/feature_list.h"
@@ skipping 1229 matching lines @@
     ~ContentSettingSubresourceFilterBubbleModel() {}
 
 void ContentSettingSubresourceFilterBubbleModel::SetTitle() {
   set_title(
       l10n_util::GetStringUTF16(IDS_FILTERED_DECEPTIVE_CONTENT_PROMPT_TITLE));
 }
 
 void ContentSettingSubresourceFilterBubbleModel::SetManageText() {
   set_manage_text(
       l10n_util::GetStringUTF8(IDS_FILTERED_DECEPTIVE_CONTENT_PROMPT_RELOAD));
-  set_show_manage_text_as_button(true);
+  set_show_manage_text_as_checkbox(true);
 }
 
 void ContentSettingSubresourceFilterBubbleModel::SetMessage() {
   set_message(l10n_util::GetStringUTF16(
       IDS_FILTERED_DECEPTIVE_CONTENT_PROMPT_EXPLANATION));
 }
 
-void ContentSettingSubresourceFilterBubbleModel::OnManageLinkClicked() {
-  subresource_filter::ContentSubresourceFilterDriverFactory* driver_factory =
-      subresource_filter::ContentSubresourceFilterDriverFactory::
-          FromWebContents(web_contents());
-  driver_factory->OnReloadRequested();
+void ContentSettingSubresourceFilterBubbleModel::OnManageCheckboxChecked(
+    bool is_checked) {
+  int string_id =
+      is_checked ? IDS_FILTERED_DECEPTIVE_CONTENT_RELOAD_ACTION : IDS_DONE;

[msw, 2017/04/06 00:44:56]

aside: It'd be nice if we could just re-use IDS_APP_MENU_RELOAD or another of
the many existing reload strings, and not add another duplicate string.

[Charlie Harrison, 2017/04/06 02:04:58]

OK, I was not sure of the best practice here, considering there are many
duplicate "Reload" strings already. I will remove it in this CL.

[msw, 2017/04/06 02:19:29]

Generally, it's good to reuse and consolidate string resources when they have
the same content and semantic meaning. I'm surprised we don't have a
cross-platform IDS_RELOAD = "Reload" already, the app menu string should
suffice, and when the underlying string changes, usage should be audited.

+  set_done_button_text(l10n_util::GetStringUTF16(string_id));
+  is_checked_ = is_checked;
+}
+
+void ContentSettingSubresourceFilterBubbleModel::OnDoneClicked() {
+  if (is_checked_) {
+    subresource_filter::ContentSubresourceFilterDriverFactory* driver_factory =
+        subresource_filter::ContentSubresourceFilterDriverFactory::
+            FromWebContents(web_contents());
+    driver_factory->OnReloadRequested();
+  }
 }
 
 ContentSettingSubresourceFilterBubbleModel*
 ContentSettingSubresourceFilterBubbleModel::AsSubresourceFilterBubbleModel() {
   return this;
 }
 
 // ContentSettingMidiSysExBubbleModel ------------------------------------------
 
 class ContentSettingMidiSysExBubbleModel
@@ skipping 274 matching lines @@
 
 ContentSettingBubbleModel::DomainList::~DomainList() {}
 
 ContentSettingBubbleModel::MediaMenu::MediaMenu() : disabled(false) {}
 
 ContentSettingBubbleModel::MediaMenu::MediaMenu(const MediaMenu& other) =
     default;
 
 ContentSettingBubbleModel::MediaMenu::~MediaMenu() {}
 
-ContentSettingBubbleModel::BubbleContent::BubbleContent()
-    : radio_group_enabled(false),
-      custom_link_enabled(false),
-      show_manage_text_as_button(false) {}
+ContentSettingBubbleModel::BubbleContent::BubbleContent() {}
 
 ContentSettingBubbleModel::BubbleContent::~BubbleContent() {}
 
 void ContentSettingBubbleModel::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
   if (type == content::NOTIFICATION_WEB_CONTENTS_DESTROYED) {
     DCHECK_EQ(web_contents_,
               content::Source<WebContents>(source).ptr());
@@ skipping 19 matching lines @@
 
 ContentSettingSubresourceFilterBubbleModel*
 ContentSettingBubbleModel::AsSubresourceFilterBubbleModel() {
   return nullptr;
 }
 
 ContentSettingDownloadsBubbleModel*
 ContentSettingBubbleModel::AsDownloadsBubbleModel() {
   return nullptr;
 }