Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: tools/clang/CMakeLists.txt

Issue 2793343002: Add --enable-pgo option to build clang with PGO
Patch Set: Add --enable-pgo option to build clang with PGO Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/PGO-stage2.cmake » ('j') | tools/clang/PGO-stage2.cmake » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/CMakeLists.txt
diff --git a/tools/clang/CMakeLists.txt b/tools/clang/CMakeLists.txt
index addcb5645183cebe3aa7519973914c223184bdf8..96ec29aaba55ccb281ac17db8ecbce3a9081933d 100644
--- a/tools/clang/CMakeLists.txt
+++ b/tools/clang/CMakeLists.txt
@@ -58,6 +58,11 @@ endfunction(cr_install)
add_custom_target(cr-install COMMAND
${CMAKE_COMMAND} -D COMPONENT=chrome-tools -P cmake_install.cmake)
-foreach(tool ${CHROMIUM_TOOLS})
- add_subdirectory(${tool})
-endforeach(tool)
+if (CHROMIUM_TOOLS)
Nico 2017/04/07 15:58:53 why this change? seems independent of the rest of
matthewtff.asm 2017/04/11 12:14:43 We do not pass -DBOOTSTRAP_CHROMIUM_TOOLS to cmake
+ # CHROMIUM_TOOLS are separated by comma. To make it iterable cmake list
+ # replace those with semicolon.
+ string(REPLACE "," ";" CHROMIUM_TOOLS_LIST ${CHROMIUM_TOOLS})
+ foreach(tool ${CHROMIUM_TOOLS_LIST})
+ add_subdirectory(${tool})
+ endforeach(tool)
+endif(CHROMIUM_TOOLS)
« no previous file with comments | « no previous file | tools/clang/PGO-stage2.cmake » ('j') | tools/clang/PGO-stage2.cmake » ('J')

Powered by Google App Engine
This is Rietveld 408576698