Remove unused call to discoverPackagesInRepository from test scripts.

Remove unused call to discoverPackagesInRepository from test scripts.

Rewrite StandardTestSuite.forEachTest using async/await.

BUG=
R=kustermann@google.com

Committed: https://github.com/dart-lang/sdk/commit/c3d4674a8c405df8f42d4d8a0039e02b18203fb4

[Bill Hesse, 2017-04-04 14:58:49]

whesse@google.com changed reviewers:
+ kustermann@google.com

[Bill Hesse, 2017-04-04 14:58:49]

https://codereview.chromium.org/2793333002/diff/1/tools/testing/dart/test_sui...
File tools/testing/dart/test_suite.dart (left):

https://codereview.chromium.org/2793333002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:749: // We rely on enqueueing completing
asynchronously.
 An await function always returns asynchronously, waiting on the event loop at
least once, so this is no longer needed.

[kustermann, 2017-04-04 15:04:11]

lgtm

https://codereview.chromium.org/2793333002/diff/1/tools/testing/dart/test_sui...
File tools/testing/dart/test_suite.dart (left):

https://codereview.chromium.org/2793333002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:749: // We rely on enqueueing completing
asynchronously.
On 2017/04/04 14:58:49, Bill Hesse wrote:
>  An await function always returns asynchronously, waiting on the event loop at
> least once, so this is no longer needed.

Acknowledged.

[kustermann, 2017-04-04 15:04:43]

https://codereview.chromium.org/2793333002/diff/1/tools/testing/dart/test_sui...
File tools/testing/dart/test_suite.dart (left):

https://codereview.chromium.org/2793333002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:733: discoverPackagesInRepository().then((Map
packageDirectories) {
Can't you get rid of the discoverPackagesInRepository() as well?

[Bill Hesse, 2017-04-04 15:22:28]

https://codereview.chromium.org/2793333002/diff/1/tools/testing/dart/test_sui...
File tools/testing/dart/test_suite.dart (left):

https://codereview.chromium.org/2793333002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:733: discoverPackagesInRepository().then((Map
packageDirectories) {
On 2017/04/04 15:04:43, kustermann wrote:
> Can't you get rid of the discoverPackagesInRepository() as well?

There is another use of it, in the PkgBuildTestSuite class.  I have an issue
filed to remove that class and the functions it uses, putting them in a
completely separate standalone test script.  This CL is work to enable that.

[Bill Hesse, 2017-04-04 15:31:50]

Description was changed from

==========
Remove unused call to discoverPackagesInRepository from test scripts.

Rewrite StandardTestSuite.forEachTest using async/await.

BUG=
==========

to

==========
Remove unused call to discoverPackagesInRepository from test scripts.

Rewrite StandardTestSuite.forEachTest using async/await.

BUG=
R=kustermann@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c3d4674a8c405df8f42d4d8a0039e02b18203fb4
==========

[Bill Hesse, 2017-04-04 15:31:52]

Committed patchset #1 (id:1) manually as
c3d4674a8c405df8f42d4d8a0039e02b18203fb4 (presubmit successful).