Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 27933002: More clang warning fixes. (Closed)

Created:
7 years, 2 months ago by tfarina
Modified:
7 years, 2 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

More clang warning fixes. Mostly unused functions and variables removed. BUG=None TEST=ninja -C out/Debug most ninja -C out/Release most R=bsalomon@google.com,robertphillips@google.com,caryclark@google.com Committed: http://code.google.com/p/skia/source/detail?r=11884

Patch Set 1 #

Patch Set 2 : trybot fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -191 lines) Patch
M bench/RTreeBench.cpp View 3 chunks +0 lines, -28 lines 0 comments Download
M bench/benchmain.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkAAClip.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/BlitRowTest.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/CanvasTest.cpp View 2 chunks +0 lines, -12 lines 0 comments Download
M tests/ClipStackTest.cpp View 1 chunk +0 lines, -23 lines 0 comments Download
M tests/ColorTest.cpp View 1 chunk +0 lines, -102 lines 0 comments Download
M tests/PathOpsAngleTest.cpp View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
Brian, Robert for everything. Cary for the pathops file. To be able to build everything ...
7 years, 2 months ago (2013-10-18 01:17:42 UTC) #1
caryclark
(for path ops test only) lgtm
7 years, 2 months ago (2013-10-18 01:58:52 UTC) #2
bsalomon
On 2013/10/18 01:58:52, caryclark wrote: > (for path ops test only) lgtm I think some ...
7 years, 2 months ago (2013-10-18 13:29:57 UTC) #3
tfarina
Brian, please, could you take another look? It was because those functions were used only ...
7 years, 2 months ago (2013-10-19 12:30:17 UTC) #4
bsalomon
lgtm
7 years, 2 months ago (2013-10-21 13:22:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/27933002/90001
7 years, 2 months ago (2013-10-21 16:13:34 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-21 16:41:04 UTC) #7
Message was sent while issue was closed.
Change committed as 11884

Powered by Google App Engine
This is Rietveld 408576698