chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java - Issue 2793253002: Log metrics for the new Default Search Engine geolocation setting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java

Issue 2793253002: Log metrics for the new Default Search Engine geolocation setting. (Closed)

Patch Set: With test Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java

index e8502dd81c96123f63c4fae59aeba615576aae5a..bb579c2d5b3a8ecc87336901350d0b796ee7355d 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java

@@ -6,6 +6,7 @@ package org.chromium.chrome.browser.infobar;

import android.support.test.filters.SmallTest;

+import org.chromium.base.metrics.RecordHistogram;

import org.chromium.base.test.util.CommandLineFlags;

import org.chromium.base.test.util.Feature;

import org.chromium.chrome.browser.ChromeActivity;

@@ -107,6 +108,14 @@ public class SearchGeolocationDisclosureInfoBarTest

SearchGeolocationDisclosureTabHelper.setDayOffsetForTesting(3);

loadUrl(mTestServer.getURL(SEARCH_PAGE));

assertEquals("Wrong infobar count after search", 0, getInfoBars().size());

+ // Check histograms have been recorded.

+ assertEquals("Wrong pre-disclosure metric", 1,

+ RecordHistogram.getHistogramValueCountForTesting(

+ "GeolocationDisclosure.PreDisclosureDSESetting", 1));

+ assertEquals("Wrong post-disclosure metric", 1,

+ RecordHistogram.getHistogramValueCountForTesting(

+ "GeolocationDisclosure.PostDisclosureDSESetting", 1));

}

@SmallTest