Chromium Code Reviews Chromium Code Reviews
Issue 2793253002:
Log metrics for the new Default Search Engine geolocation setting. (Closed)
| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 31774c7ed82606dfcfe74fdb4a4a19feb94b0f78..3fb586853179c98f7ff8405c69393cfa466d97f9 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -21335,6 +21335,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="GeolocationDisclosure.PostDisclosureDSESetting" enum="Boolean"> |
|
Ilya Sherman
2017/04/07 08:09:33
nit: (Just within this file), please provide a cus
benwells
2017/04/10 08:41:44
Good point - it's 'allow' vs. 'disallow'. Done.
|
| + <owner>benwells@chromium.org</owner> |
| + <summary> |
| + Records the geolocation default search engine setting after the search |
| + geolocation disclosure has been shown and won't be shown again. This metric |
| + is only recorded once per client. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="GeolocationDisclosure.PostDisclosurePermission" |
| enum="PermissionStatus"> |
| <obsolete> |
| @@ -21358,6 +21367,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="GeolocationDisclosure.PreDisclosureDSESetting" enum="Boolean"> |
|
Ilya Sherman
2017/04/07 08:09:33
nit: (Ditto)
benwells
2017/04/10 08:41:44
Done.
|
| + <owner>benwells@chromium.org</owner> |
| + <summary> |
| + Records the geolocation default search engine setting immediately before the |
| + search geolocation disclosure has been shown. This metric is only recorded |
| + once per client. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="GeolocationDisclosure.PreDisclosurePermission" |
| enum="PermissionStatus"> |
| <obsolete> |
