third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp - Issue 2793233002: Remove begin/end subseq. display items, and store on PaintController instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp

Issue 2793233002: Remove begin/end subseq. display items, and store on PaintController instead. (Closed)

Patch Set: none Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/BUILD.gn ('k') | third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h » ('j') | third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp b/third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp

index cca3328f15e5b547dcbfdca3b5dc1734896adcd2..05790aff6dd41caeee6f665c5b9316640ca99a18 100644

--- a/third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp

+++ b/third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp

@@ -181,9 +181,7 @@ static void recordPairedEndDisplayItems(

static gfx::Rect largeRect(-200000, -200000, 400000, 400000);

static void appendDisplayItemToCcDisplayItemList(const DisplayItem& displayItem,

cc::DisplayItemList* list) {

- DCHECK(DisplayItem::isDrawingType(displayItem.getType()) ||

- displayItem.getType() == DisplayItem::kSubsequence ||

- displayItem.getType() == DisplayItem::kEndSubsequence);

+ DCHECK(DisplayItem::isDrawingType(displayItem.getType()));

if (DisplayItem::isDrawingType(displayItem.getType())) {

sk_sp<const PaintRecord> record =

static_cast<const DrawingDisplayItem&>(displayItem).GetPaintRecord();