Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp

Issue 2793233002: Remove begin/end subseq. display items, and store on PaintController instead. (Closed)
Patch Set: none Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp
index 8b3187376a9d8bb8e1c542b09a76a4f59f4378ad..c765760c144bc432f713802cb09037e42a1fc1a4 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp
+++ b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp
@@ -8,7 +8,6 @@
#include "platform/graphics/paint/DrawingDisplayItem.h"
#include "platform/graphics/paint/PaintFlags.h"
#include "platform/graphics/paint/PaintRecorder.h"
-#include "platform/graphics/paint/SubsequenceDisplayItem.h"
#include "platform/graphics/skia/SkiaUtils.h"
#include "platform/testing/FakeDisplayItemClient.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -62,24 +61,14 @@ TEST_F(DisplayItemListTest, AppendVisualRect_BlockContainingDrawing) {
// represent the union of all drawing display item visual rects between the
// pair. We should consider revising Blink's display item list in some form
// so as to only store visual rects for drawing display items.
-
- IntRect subsequenceBounds(5, 6, 7, 8);
- m_list.allocateAndConstruct<BeginSubsequenceDisplayItem>(m_client);
- m_list.appendVisualRect(subsequenceBounds);
-
IntRect drawingBounds(5, 6, 1, 1);
m_list.allocateAndConstruct<DrawingDisplayItem>(
m_client, DisplayItem::Type::kDocumentBackground,
createRectRecord(drawingBounds), true);
m_list.appendVisualRect(drawingBounds);
- m_list.allocateAndConstruct<EndSubsequenceDisplayItem>(m_client);
- m_list.appendVisualRect(subsequenceBounds);
-
- EXPECT_EQ(static_cast<size_t>(3), m_list.size());
- EXPECT_RECT_EQ(subsequenceBounds, m_list.visualRect(0));
- EXPECT_RECT_EQ(drawingBounds, m_list.visualRect(1));
- EXPECT_RECT_EQ(subsequenceBounds, m_list.visualRect(2));
+ EXPECT_EQ(static_cast<size_t>(1), m_list.size());
+ EXPECT_RECT_EQ(drawingBounds, m_list.visualRect(0));
}
} // namespace
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698