Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 279323002: Revert 269791 "Pepper: Fix crash on allocation failure." (Closed)

Created:
6 years, 7 months ago by piman
Modified:
6 years, 7 months ago
Reviewers:
teravest
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 269791 "Pepper: Fix crash on allocation failure." Likely cause to ASAN issues in http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20Tests%20%28sandboxed%29/builds/1616/steps/browser_tests/logs/stdio > Pepper: Fix crash on allocation failure. > > GetPNaClResourceInfo() currently performs a 1 megabyte allocation. Though any > memory allocation can fail, this one is more likely due to its size. > > This change mitigates this problem in two ways. If memory allocation fails, we > report an error and return early instead of using memory. > > Additionally, this change checks the size of the file before performing a > memory allocation. This should lead to smaller allocations and more successful > plugin loads. > > BUG=370965 > > Review URL: https://codereview.chromium.org/274673002 TBR=teravest@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269876

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -26 lines) Patch
M trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc View 1 chunk +4 lines, -26 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
piman
6 years, 7 months ago (2014-05-12 21:10:16 UTC) #1
piman
Committed patchset #1 manually as r269876.
6 years, 7 months ago (2014-05-12 21:10:24 UTC) #2
teravest
6 years, 7 months ago (2014-05-12 21:10:33 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698