DescriptionRevert 269791 "Pepper: Fix crash on allocation failure."
Likely cause to ASAN issues in http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20Tests%20%28sandboxed%29/builds/1616/steps/browser_tests/logs/stdio
> Pepper: Fix crash on allocation failure.
>
> GetPNaClResourceInfo() currently performs a 1 megabyte allocation. Though any
> memory allocation can fail, this one is more likely due to its size.
>
> This change mitigates this problem in two ways. If memory allocation fails, we
> report an error and return early instead of using memory.
>
> Additionally, this change checks the size of the file before performing a
> memory allocation. This should lead to smaller allocations and more successful
> plugin loads.
>
> BUG=370965
>
> Review URL: https://codereview.chromium.org/274673002
TBR=teravest@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269876
Patch Set 1 #
Messages
Total messages: 3 (0 generated)
|