Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js

Issue 2793203002: [DevTools] Pass sidebar and not the panel. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js b/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
index 8c8805afa877403023ce4b007fb9029c61cdd243..3a030292d9bbea8d691b35f6e0df6b9533005604 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
@@ -611,6 +611,7 @@ Resources.BaseStorageTreeElement = class extends UI.TreeElement {
*/
constructor(storagePanel, title, expandable) {
super(title, expandable);
+ console.assert(storagePanel);
dgozman 2017/04/04 16:48:30 It is marked as non-nullable. Don't assert.
eostroukhov 2017/04/04 17:31:37 Done.
this._storagePanel = storagePanel;
}
@@ -736,7 +737,7 @@ Resources.DatabaseTreeElement = class extends Resources.BaseStorageTreeElement {
function tableNamesCallback(tableNames) {
var tableNamesLength = tableNames.length;
for (var i = 0; i < tableNamesLength; ++i)
- this.appendChild(new Resources.DatabaseTableTreeElement(this._storagePanel, this._database, tableNames[i]));
+ this.appendChild(new Resources.DatabaseTableTreeElement(this._sidebar, this._database, tableNames[i]));
}
this._database.getTableNames(tableNamesCallback.bind(this));
}
@@ -746,6 +747,11 @@ Resources.DatabaseTreeElement = class extends Resources.BaseStorageTreeElement {
* @unrestricted
*/
Resources.DatabaseTableTreeElement = class extends Resources.BaseStorageTreeElement {
+ /**
+ * @param {!Resources.ApplicationPanelSidebar} sidebar
+ * @param {!Resources.Database} database
+ * @param {string} tableName
+ */
constructor(sidebar, database, tableName) {
super(sidebar._panel, tableName, false);
this._sidebar = sidebar;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698