Do not embed is_auto_setup_scope into the compilation of native calls.

runtime/vm/simulator_dbc.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <setjmp.h>  // NOLINT
 #include <stdlib.h>
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_DBC)
 
@@ skipping 912 matching lines @@
     drt(args);
     thread->set_vm_tag(VMTag::kDartTagId);
     thread->set_top_exit_frame_info(0);
     return true;
   } else {
     return false;
   }
 }
 
 
-static DART_NOINLINE bool InvokeNative(Thread* thread,
-                                       Simulator* sim,
-                                       SimulatorBootstrapNativeCall f,
-                                       NativeArguments* args) {
+static DART_NOINLINE bool InvokeBootstrapNative(Thread* thread,
+                                                Simulator* sim,
+                                                SimulatorBootstrapNativeCall f,
+                                                NativeArguments* args) {
   SimulatorSetjmpBuffer buffer(sim);
   if (!setjmp(buffer.buffer_)) {
     thread->set_vm_tag(reinterpret_cast<uword>(f));
     f(args);
     thread->set_vm_tag(VMTag::kDartTagId);
     thread->set_top_exit_frame_info(0);
     return true;
   } else {
     return false;
   }
 }
 
 
-static DART_NOINLINE bool InvokeNativeWrapper(Thread* thread,
-                                              Simulator* sim,
-                                              Dart_NativeFunction f,
-                                              NativeArguments* args) {
+static DART_NOINLINE bool InvokeNativeNoScopeWrapper(Thread* thread,
+                                                     Simulator* sim,
+                                                     Dart_NativeFunction f,
+                                                     NativeArguments* args) {
   SimulatorSetjmpBuffer buffer(sim);
   if (!setjmp(buffer.buffer_)) {
     thread->set_vm_tag(reinterpret_cast<uword>(f));
-    NativeEntry::NativeCallWrapper(reinterpret_cast<Dart_NativeArguments>(args),
-                                   f);
+    NativeEntry::NoScopeNativeCallWrapper(
+        reinterpret_cast<Dart_NativeArguments>(args), f);
     thread->set_vm_tag(VMTag::kDartTagId);
     thread->set_top_exit_frame_info(0);
     return true;
+  } else {
+    return false;
+  }
+}
+
+
+static DART_NOINLINE bool InvokeNativeAutoScopeWrapper(Thread* thread,
+                                                       Simulator* sim,
+                                                       Dart_NativeFunction f,
+                                                       NativeArguments* args) {
+  SimulatorSetjmpBuffer buffer(sim);
+  if (!setjmp(buffer.buffer_)) {
+    thread->set_vm_tag(reinterpret_cast<uword>(f));
+    NativeEntry::AutoScopeNativeCallWrapper(
+        reinterpret_cast<Dart_NativeArguments>(args), f);
+    thread->set_vm_tag(VMTag::kDartTagId);
+    thread->set_top_exit_frame_info(0);
+    return true;
   } else {
     return false;
   }
 }
 
 // Note: all macro helpers are intended to be used only inside Simulator::Call.
 
 // Decode opcode and A part of the given value and dispatch to the
 // corresponding bytecode handler.
 #define DISPATCH_OP(val)                                                       \
@@ skipping 113 matching lines @@
     pp = SimulatorHelpers::FrameCode(FP)->ptr()->object_pool_->ptr();          \
     goto DispatchAfterException;                                               \
   } while (0)
 
 // Runtime call helpers: handle invocation and potential exception after return.
 #define INVOKE_RUNTIME(Func, Args)                                             \
   if (!InvokeRuntime(thread, this, Func, Args)) {                              \
     HANDLE_EXCEPTION;                                                          \
   }
 
-#define INVOKE_NATIVE(Func, Args)                                              \
-  if (!InvokeNative(thread, this, Func, &Args)) {                              \
+#define INVOKE_BOOTSTRAP_NATIVE(Func, Args)                                    \
+  if (!InvokeBootstrapNative(thread, this, Func, &Args)) {                     \
     HANDLE_EXCEPTION;                                                          \
   }
 
-#define INVOKE_NATIVE_WRAPPER(Func, Args)                                      \
-  if (!InvokeNativeWrapper(thread, this, Func, &Args)) {                       \
+#define INVOKE_NATIVE_NO_SCOPE(Func, Args)                                     \
+  if (!InvokeNativeNoScopeWrapper(thread, this, Func, &Args)) {                \
     HANDLE_EXCEPTION;                                                          \
   }
 
+#define INVOKE_NATIVE_AUTO_SCOPE(Func, Args)                                   \
+  if (!InvokeNativeAutoScopeWrapper(thread, this, Func, &Args)) {              \
+    HANDLE_EXCEPTION;                                                          \
+  }
+
 #define LOAD_CONSTANT(index) (pp->data()[(index)].raw_obj_)
 
 
 // Returns true if deoptimization succeeds.
 DART_FORCE_INLINE bool Simulator::Deoptimize(Thread* thread,
                                              RawObjectPool** pp,
                                              uint32_t** pc,
                                              RawObject*** FP,
                                              RawObject*** SP,
                                              bool is_lazy) {
@@ skipping 772 matching lines @@
             ? FrameArguments(FP, function->ptr()->num_fixed_parameters_)
             : FP;
 
     SimulatorBootstrapNativeCall native_target =
         reinterpret_cast<SimulatorBootstrapNativeCall>(SP[-1]);
     intptr_t argc_tag = reinterpret_cast<intptr_t>(SP[-0]);
     SP[-0] = 0;  // Note: argc_tag is not smi-tagged.
     SP[-1] = null_value;
     Exit(thread, FP, SP + 1, pc);
     NativeArguments args(thread, argc_tag, incoming_args, SP - 1);
-    INVOKE_NATIVE(native_target, args);
+    INVOKE_BOOTSTRAP_NATIVE(native_target, args);
     SP -= 1;
     DISPATCH();
   }
 
   {
-    BYTECODE(NativeCall, 0);
+    BYTECODE(NativeNoScopeCall, 0);
     RawFunction* function = FrameFunction(FP);
     RawObject** incoming_args =
         (function->ptr()->num_optional_parameters_ == 0)
+            ? FrameArguments(FP, function->ptr()->num_fixed_parameters_)
+            : FP;
+
+    Dart_NativeFunction native_target =
+        reinterpret_cast<Dart_NativeFunction>(SP[-1]);
+    intptr_t argc_tag = reinterpret_cast<intptr_t>(SP[-0]);
+    SP[-0] = 0;  // argc_tag is not smi tagged!
+    SP[-1] = null_value;
+    Exit(thread, FP, SP + 1, pc);
+    NativeArguments args(thread, argc_tag, incoming_args, SP - 1);
+    INVOKE_NATIVE_NO_SCOPE(native_target, args);
+    SP -= 1;
+    DISPATCH();
+  }
+
+  {
+    BYTECODE(NativeAutoScopeCall, 0);
+    RawFunction* function = FrameFunction(FP);
+    RawObject** incoming_args =
+        (function->ptr()->num_optional_parameters_ == 0)
             ? FrameArguments(FP, function->ptr()->num_fixed_parameters_)
             : FP;
 
     Dart_NativeFunction native_target =
         reinterpret_cast<Dart_NativeFunction>(SP[-1]);
     intptr_t argc_tag = reinterpret_cast<intptr_t>(SP[-0]);
     SP[-0] = 0;  // argc_tag is not smi tagged!
     SP[-1] = null_value;
     Exit(thread, FP, SP + 1, pc);
     NativeArguments args(thread, argc_tag, incoming_args, SP - 1);
-    INVOKE_NATIVE_WRAPPER(native_target, args);
+    INVOKE_NATIVE_AUTO_SCOPE(native_target, args);
     SP -= 1;
     DISPATCH();
   }
 
   {
     BYTECODE(OneByteStringFromCharCode, A_X);
     const intptr_t char_code = Smi::Value(RAW_CAST(Smi, FP[rD]));
     ASSERT(char_code >= 0);
     ASSERT(char_code <= 255);
     RawString** strings = Symbols::PredefinedAddress();
@@ skipping 1881 matching lines @@
     pc_ = pc;
   }
 
   buf->Longjmp();
   UNREACHABLE();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_DBC