courgette/disassembler_elf_32_x86_unittest.cc - Issue 2793153003: [Courgette] Refactor: Store Label Annotation in AssemblyProgram for patch generation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: courgette/disassembler_elf_32_x86_unittest.cc

Issue 2793153003: [Courgette] Refactor: Store Label Annotation in AssemblyProgram for patch generation. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: courgette/disassembler_elf_32_x86_unittest.cc

diff --git a/courgette/disassembler_elf_32_x86_unittest.cc b/courgette/disassembler_elf_32_x86_unittest.cc

index d42f7093eff8244e28eb45f1260656d97ddde8b3..d44defcd7fe6e80f3d9b40675a1f788638f7fd61 100644

--- a/courgette/disassembler_elf_32_x86_unittest.cc

+++ b/courgette/disassembler_elf_32_x86_unittest.cc

@@ -91,7 +91,7 @@ void DisassemblerElf32X86Test::TestExe(const char* file_name,

EXPECT_EQ('L', offset_p[2]);

EXPECT_EQ('F', offset_p[3]);

- std::unique_ptr<AssemblyProgram> program = disassembler->Disassemble();

+ std::unique_ptr<AssemblyProgram> program = disassembler->Disassemble(false);

EXPECT_TRUE(nullptr != program.get());

const std::vector<RVA>& abs32_list = disassembler->Abs32Locations();