Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: courgette/courgette_tool.cc

Issue 2793153003: [Courgette] Refactor: Store Label Annotation in AssemblyProgram for patch generation. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: courgette/courgette_tool.cc
diff --git a/courgette/courgette_tool.cc b/courgette/courgette_tool.cc
index 70b177b817c40b269a8fa7215f65131cfe634367..e9cf99e36fe1b7dcfa15383ab1d3a0d1e94dcdd5 100644
--- a/courgette/courgette_tool.cc
+++ b/courgette/courgette_tool.cc
@@ -214,17 +214,18 @@ void DisassembleAdjustDiff(const base::FilePath& model_file,
BufferedFileReader model_buffer(model_file, "old");
BufferedFileReader program_buffer(program_file, "new");
+ auto parser = adjust ? courgette::ParseDetectedExecutableWithAnnotation
+ : courgette::ParseDetectedExecutable;
+
std::unique_ptr<courgette::AssemblyProgram> model;
const courgette::Status parse_model_status =
- courgette::ParseDetectedExecutable(model_buffer.data(),
- model_buffer.length(), &model);
+ parser(model_buffer.data(), model_buffer.length(), &model);
if (parse_model_status != courgette::C_OK)
Problem("Can't parse model input (code = %d).", parse_model_status);
std::unique_ptr<courgette::AssemblyProgram> program;
const courgette::Status parse_program_status =
- courgette::ParseDetectedExecutable(program_buffer.data(),
- program_buffer.length(), &program);
+ parser(program_buffer.data(), program_buffer.length(), &program);
if (parse_program_status != courgette::C_OK)
Problem("Can't parse program input (code = %d).", parse_program_status);

Powered by Google App Engine
This is Rietveld 408576698