Create Document exitPointerLock and pointerLockElement API methods.

Create Document exitPointerLock and pointerLockElement API methods.

Part of the larger task of creating an unprefixed Pointer Lock API.
Intent to Implement and Ship approved April 21 2014
http://goo.gl/uQTJjH.

BUG=359738
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174201

[Inactive, 2014-05-12 21:29:28]

https://codereview.chromium.org/279313003/diff/1/Source/core/dom/Document.idl
File Source/core/dom/Document.idl (right):

https://codereview.chromium.org/279313003/diff/1/Source/core/dom/Document.idl...
Source/core/dom/Document.idl:165: [MeasureAs=PrefixedDocumentExitPointerLock]
void webkitExitPointerLock();
We could use [ImplementedAs=exitPointerLock] and rename the method on native
side to avoid having both prefixed / unprefixed methods on native side.

https://codereview.chromium.org/279313003/diff/1/Source/core/dom/Document.idl...
Source/core/dom/Document.idl:166: [MeasureAs=DocumentExitPointerLock] void
exitPointerLock();
Why are we measuring the usage of the unprefixed ones?

https://codereview.chromium.org/279313003/diff/1/Source/core/dom/Document.idl...
Source/core/dom/Document.idl:167: [MeasureAs=PrefixedDocumentPointerLockElement]
readonly attribute Element webkitPointerLockElement;
Ditto ([ImplementedAs]).

[scheib, 2014-05-12 22:24:09]

Thanks Chris,

https://codereview.chromium.org/279313003/diff/1/Source/core/dom/Document.idl
File Source/core/dom/Document.idl (right):

https://codereview.chromium.org/279313003/diff/1/Source/core/dom/Document.idl...
Source/core/dom/Document.idl:165: [MeasureAs=PrefixedDocumentExitPointerLock]
void webkitExitPointerLock();
On 2014/05/12 21:29:29, Chris Dumez wrote:
> We could use [ImplementedAs=exitPointerLock] and rename the method on native
> side to avoid having both prefixed / unprefixed methods on native side.

Done.

https://codereview.chromium.org/279313003/diff/1/Source/core/dom/Document.idl...
Source/core/dom/Document.idl:166: [MeasureAs=DocumentExitPointerLock] void
exitPointerLock();
On 2014/05/12 21:29:29, Chris Dumez wrote:
> Why are we measuring the usage of the unprefixed ones?

To consider the eventual migration of usage from the prefixed version of the API
to unprefixed we should measure the prefixed:unprefixed ratio. The API is
critical to only a narrow application set, so we don't anticipate generally
large numbers.

https://codereview.chromium.org/279313003/diff/1/Source/core/dom/Document.idl...
Source/core/dom/Document.idl:167: [MeasureAs=PrefixedDocumentPointerLockElement]
readonly attribute Element webkitPointerLockElement;
On 2014/05/12 21:29:29, Chris Dumez wrote:
> Ditto ([ImplementedAs]).

Done.

[scheib, 2014-05-14 17:46:34]

eseidel, API OWNERS review please.

[eseidel, 2014-05-16 15:26:28]

lgtm

[commit-bot: I haz the power, 2014-05-16 15:26:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scheib@chromium.org/279313003/20001

[commit-bot: I haz the power, 2014-05-16 15:27:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-16 15:27:17]

Failed to apply patch for Source/core/frame/UseCounter.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/UseCounter.h
  Hunk #1 FAILED at 421.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/UseCounter.h.rej

Patch:       Source/core/frame/UseCounter.h
Index: Source/core/frame/UseCounter.h
diff --git a/Source/core/frame/UseCounter.h b/Source/core/frame/UseCounter.h
index
c1d8d3ac32d5f68732382a1de7389d9bd77af365..c3dd3c1720f60112d1693727603bf0e1753a1886
100644
--- a/Source/core/frame/UseCounter.h
+++ b/Source/core/frame/UseCounter.h
@@ -421,6 +421,8 @@ public:
         VTTCueRenderAlignNotMiddle = 416,
         ElementRequestPointerLock = 417,
         VTTCueRenderRtl = 418,
+        DocumentExitPointerLock = 419,
+        DocumentPointerLockElement = 420,
         // Add new features immediately above this line. Don't change assigned
         // numbers of any item, and don't reuse removed slots.
         // Also, run update_use_counter_feature_enum.py in
chromium/src/tools/metrics/histograms/

[scheib, 2014-05-16 16:46:18]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2014-05-16 16:46:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scheib@chromium.org/279313003/40001

[commit-bot: I haz the power, 2014-05-16 18:22:29]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/7408)

[commit-bot: I haz the power, 2014-05-16 19:07:47]

Change committed as 174201