Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2793113002: Convert constructor initializers in endInitializers() and other tweaks. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Convert constructor initializers in endInitializers() and other tweaks. R=paulberry@google.com, ahe@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/cd5de6deeff0dd59efbff9fa305496ed932ccc84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -82 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 3 chunks +55 lines, -53 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 3 chunks +2 lines, -24 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-03 17:57:37 UTC) #1
Paul Berry
lgtm
3 years, 8 months ago (2017-04-03 18:45:35 UTC) #2
scheglov
3 years, 8 months ago (2017-04-03 18:59:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cd5de6deeff0dd59efbff9fa305496ed932ccc84 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698