Description[Extensions Bindings] Add an end-to-end test for the fileSystem API
Add an end-to-end test for the fileSystem API, which exercises a few
different niche properties:
a) It has an unusual isInstanceOf property (Entry)
b) It hacks up the arguments with a setUpdateArgumentsPostValidate hook
c) It uses some craziness to bind file entries to the background page
a) is already implemented, but this adds an end-to-end test for it.
b) required updating logic to no longer parse and validate arguments
after a post-update hook. This is unfortunate (see comments for why),
but a number of APIs do this, so for now, we have to support it. Add
a few comments lamenting the state, and a test to ensure it doesn't
break.
c) required updating the util js module to not require the method from
the API module's custom bindings, since an API instantiated through a
require() won't have the apiBridge passed in. APIs should be instatiated
through the lazy get; utils should be require()d.
BUG=653596
Review-Url: https://codereview.chromium.org/2793033002
Cr-Commit-Position: refs/heads/master@{#461976}
Committed: https://chromium.googlesource.com/chromium/src/+/577b8f369864082950e5922472780e54317ea2ac
Patch Set 1 : . #Depends on Patchset: Messages
Total messages: 26 (21 generated)
|