Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 279273003: Removes some unneeded code from MenuModelAdapter (Closed)

Created:
6 years, 7 months ago by sky
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Removes some unneeded code from MenuModelAdapter ViewEventTestBase (which this subclasses) installs a views_delegate, so we don't need it here too. BUG=none TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269933

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/browser/ui/views/menu_model_adapter_test.cc View 3 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
6 years, 7 months ago (2014-05-12 17:41:00 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 7 months ago (2014-05-12 18:07:33 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 7 months ago (2014-05-12 18:08:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/279273003/1
6 years, 7 months ago (2014-05-12 18:11:18 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 00:10:30 UTC) #5
Message was sent while issue was closed.
Change committed as 269933

Powered by Google App Engine
This is Rietveld 408576698