Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 279263002: Revert of suppress memory leaks from ui::GestureProviderAura::GestureProviderAura (Closed)

Created:
6 years, 7 months ago by tdresser
Modified:
6 years, 7 months ago
Reviewers:
zhaoqin
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Revert of suppress memory leaks from ui::GestureProviderAura::GestureProviderAura (https://codereview.chromium.org/278173002/) Reason for revert: The unified GR was reverted, so this suppression is not necessary. TBR=zhaoqin Original issue's description: > suppress memory leaks from ui::GestureProviderAura::GestureProviderAura > > TBR=tdresser@chromium.org > BUG=372143 > TEST=waterfall > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269580 TBR=zhaoqin@google.com NOTREECHECKS=true NOTRY=true BUG=372143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tdresser
Created Revert of suppress memory leaks from ui::GestureProviderAura::GestureProviderAura
6 years, 7 months ago (2014-05-12 15:18:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/279263002/1
6 years, 7 months ago (2014-05-12 15:19:12 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-12 15:20:06 UTC) #3
commit-bot: I haz the power
Failed to apply patch for tools/valgrind/memcheck/suppressions.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-05-12 15:20:07 UTC) #4
tdresser
6 years, 7 months ago (2014-05-12 15:23:58 UTC) #5
On 2014/05/12 15:18:34, tdresser wrote:
> Created Revert of suppress memory leaks from
> ui::GestureProviderAura::GestureProviderAura

Landing https://codereview.chromium.org/282573002/ instead.

Powered by Google App Engine
This is Rietveld 408576698