Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: src/objects.cc

Issue 2792623002: Track large array buffer allocations. (Closed)
Patch Set: Fix issues raised by bbudge Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/counters.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index fe386ae12723afe650cdeae7ecefed1753a18ea8..bb9cea43a49d324ec4ed2d43ea2d90f4b9c37756 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -19473,6 +19473,14 @@ bool JSArrayBuffer::SetupAllocatingData(Handle<JSArrayBuffer> array_buffer,
// Prevent creating array buffers when serializing.
DCHECK(!isolate->serializer_enabled());
if (allocated_length != 0) {
+ constexpr size_t kMinBigAllocation = 1 << 20;
+ if (allocated_length >= kMinBigAllocation) {
+ isolate->counters()->array_buffer_big_allocations()->AddSample(
+ static_cast<int>(
+ sizeof(size_t) == 32
+ ? (32 - base::bits::CountLeadingZeros32(allocated_length))
+ : (64 - base::bits::CountLeadingZeros64(allocated_length))));
bbudge 2017/03/31 20:52:28 You could also just do: sizeof(uint64_t) * kBitsP
Mircea Trofin 2017/03/31 21:01:38 The pointer sizes are something that may be fishab
kschimpf 2017/03/31 21:11:02 The recommendation is NOT to use value 0 in UMA hi
kschimpf 2017/03/31 21:11:02 size_t is the number of bytes. Using uint64_t, as
+ }
if (initialize) {
data = isolate->array_buffer_allocator()->Allocate(allocated_length);
} else {
« no previous file with comments | « src/counters.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698