Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2058)

Unified Diff: ui/aura/mus/window_tree_client.cc

Issue 2792573003: Update PointerEvent handled state correctly in OnWindowInputEvent. (Closed)
Patch Set: MapEvent Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/aura/mus/window_tree_client.cc
diff --git a/ui/aura/mus/window_tree_client.cc b/ui/aura/mus/window_tree_client.cc
index c3bdece523a654b38ceff5cfb6df6c1b0b94852b..51c4a72972d13c7665fdbd7e0f760af20cd1509d 100644
--- a/ui/aura/mus/window_tree_client.cc
+++ b/ui/aura/mus/window_tree_client.cc
@@ -162,6 +162,19 @@ void ConvertEventLocationToDip(int64_t display_id, ui::LocatedEvent* event) {
event->set_root_location(root_location);
}
+std::unique_ptr<ui::Event> MapEvent(const ui::Event& event) {
+ if (event.IsMousePointerEvent()) {
+ if (event.type() == ui::ET_POINTER_WHEEL_CHANGED)
+ return base::MakeUnique<ui::MouseWheelEvent>(*event.AsPointerEvent());
+ else
+ return base::MakeUnique<ui::MouseEvent>(*event.AsPointerEvent());
+ } else if (event.IsTouchPointerEvent()) {
+ return base::MakeUnique<ui::TouchEvent>(*event.AsPointerEvent());
+ } else {
+ return ui::Event::Clone(event);
+ }
+}
sadrul 2017/03/31 19:02:08 You don't need a lot of the else's. if (..)
riajiang 2017/03/31 19:30:07 Done.
+
// Set the |target| to be the target window of this |event| and send it to
// the EventSink.
void DispatchEventToTarget(ui::Event* event, WindowMus* target) {
@@ -1238,21 +1251,9 @@ void WindowTreeClient::OnWindowInputEvent(uint32_t event_id,
EventAckHandler ack_handler(CreateEventResultCallback(event_id));
// TODO(moshayedi): crbug.com/617222. No need to convert to ui::MouseEvent or
// ui::TouchEvent once we have proper support for pointer events.
- if (event->IsMousePointerEvent()) {
- if (event->type() == ui::ET_POINTER_WHEEL_CHANGED) {
- ui::MouseWheelEvent mapped_event(*event->AsPointerEvent());
- DispatchEventToTarget(&mapped_event, window);
- } else {
- ui::MouseEvent mapped_event(*event->AsPointerEvent());
- DispatchEventToTarget(&mapped_event, window);
- }
- } else if (event->IsTouchPointerEvent()) {
- ui::TouchEvent mapped_event(*event->AsPointerEvent());
- DispatchEventToTarget(&mapped_event, window);
- } else {
- DispatchEventToTarget(event.get(), window);
- }
- ack_handler.set_handled(event->handled());
+ std::unique_ptr<ui::Event> mapped_event = MapEvent(*event.get());
+ DispatchEventToTarget(mapped_event.get(), window);
+ ack_handler.set_handled(mapped_event->handled());
}
void WindowTreeClient::OnPointerEventObserved(std::unique_ptr<ui::Event> event,
« no previous file with comments | « no previous file | ui/aura/mus/window_tree_client_unittest.cc » ('j') | ui/aura/mus/window_tree_client_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698