Issue 279243002: Cleanup browser_options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 279243002: Cleanup browser_options. (Closed)

Created:
6 years, 7 months ago by Marc Treib

Modified:
6 years, 7 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cleanup browser_options: Remove unnecessary special case for supervised users in browser_options_handler.cc. Make clear that some supervised user code in browser_options.js applies only to ChromeOS. BUG=372381 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270064

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -13 lines)			Patch
	M	chrome/browser/resources/options/browser_options.js	View		1 chunk	+8 lines, -7 lines	1 comment	Download
	M	chrome/browser/ui/webui/options/browser_options_handler.cc	View		1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Marc Treib

https://codereview.chromium.org/279243002/diff/1/chrome/browser/resources/options/browser_options.js File chrome/browser/resources/options/browser_options.js (right): https://codereview.chromium.org/279243002/diff/1/chrome/browser/resources/options/browser_options.js#newcode848 chrome/browser/resources/options/browser_options.js:848: $('account-picture-wrapper').hidden = false; E.g. account-picture-wrapper and sync-general only exist ...

6 years, 7 months ago (2014-05-12 16:26:50 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/279243002/1

6 years, 7 months ago (2014-05-13 07:15:54 UTC) #4

Message was sent while issue was closed.

Change committed as 270064

Expand Messages | Collapse Messages