chrome/renderer/chrome_content_renderer_client.cc - Issue 2792233003: Split SpellCheckPanel off SpellCheckProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 2792233003: Split SpellCheckPanel off SpellCheckProvider (Closed)

Patch Set: Fix further compile error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/chrome_content_renderer_client.cc

diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc

index 2dbfadb6d614bf53e152af3cb16a48aeafdf7040..77fd3cadaba22631c2b2c6b4747a090a3ef09c0f 100644

--- a/chrome/renderer/chrome_content_renderer_client.cc

+++ b/chrome/renderer/chrome_content_renderer_client.cc

@@ -160,6 +160,7 @@

#if BUILDFLAG(ENABLE_SPELLCHECK)

#include "components/spellcheck/renderer/spellcheck.h"

+#include "components/spellcheck/renderer/spellcheck_panel.h"

#include "components/spellcheck/renderer/spellcheck_provider.h"

#endif

@@ -573,6 +574,7 @@ void ChromeContentRendererClient::RenderViewCreated(

#endif

#if BUILDFLAG(ENABLE_SPELLCHECK)

new SpellCheckProvider(render_view, spellcheck_.get());

+ new SpellCheckPanel(render_view);

groby-ooo-7-16 2017/04/05 21:19:54 Since the panel is OSX only, can we add it on OSX

#endif

new prerender::PrerendererClient(render_view);