Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4265)

Unified Diff: chrome/browser/chromeos/file_system_provider/provided_file_system.cc

Issue 279213002: [fsp] Add support for closing files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/provided_file_system.cc
diff --git a/chrome/browser/chromeos/file_system_provider/provided_file_system.cc b/chrome/browser/chromeos/file_system_provider/provided_file_system.cc
index 72bdac4282bcaa9a1d0b0ba641a2720a2fc3b7c3..8e807ad469722407a238f80f416b669ff1fbdd53 100644
--- a/chrome/browser/chromeos/file_system_provider/provided_file_system.cc
+++ b/chrome/browser/chromeos/file_system_provider/provided_file_system.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/chromeos/file_system_provider/provided_file_system.h"
#include "base/files/file.h"
+#include "chrome/browser/chromeos/file_system_provider/operations/close_file.h"
#include "chrome/browser/chromeos/file_system_provider/operations/get_metadata.h"
#include "chrome/browser/chromeos/file_system_provider/operations/open_file.h"
#include "chrome/browser/chromeos/file_system_provider/operations/read_directory.h"
@@ -59,15 +60,14 @@ void ProvidedFileSystem::ReadDirectory(
}
}
-void ProvidedFileSystem::OpenFile(
- const base::FilePath& file_path,
- OpenFileMode mode,
- bool create,
- const fileapi::AsyncFileUtil::StatusCallback& callback) {
+void ProvidedFileSystem::OpenFile(const base::FilePath& file_path,
+ OpenFileMode mode,
+ bool create,
+ const OpenFileCallback& callback) {
// Writing is not supported. Note, that this includes a situation, when a file
// exists, but |create| is set to true.
if (mode == OPEN_FILE_MODE_WRITE || create) {
- callback.Run(base::File::FILE_ERROR_SECURITY);
+ callback.Run(0 /* file_handle */, base::File::FILE_ERROR_SECURITY);
return;
}
@@ -79,6 +79,17 @@ void ProvidedFileSystem::OpenFile(
mode,
create,
callback)))) {
+ callback.Run(0 /* file_handle */, base::File::FILE_ERROR_SECURITY);
+ }
+}
+
+void ProvidedFileSystem::CloseFile(
+ int file_handle,
+ const fileapi::AsyncFileUtil::StatusCallback& callback) {
+ if (!request_manager_.CreateRequest(
+ scoped_ptr<RequestManager::HandlerInterface>(
+ new operations::CloseFile(
+ event_router_, file_system_info_, file_handle, callback)))) {
callback.Run(base::File::FILE_ERROR_SECURITY);
}
}

Powered by Google App Engine
This is Rietveld 408576698