Factor out RenderWidgetHostConnector

content/browser/renderer_host/render_widget_host_view_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_android.h"
 
 #include <android/bitmap.h>
 
 #include <utility>
 
@@ skipping 479 matching lines @@
 
   if (GetTextInputManager())
     GetTextInputManager()->AddObserver(this);
 }
 
 RenderWidgetHostViewAndroid::~RenderWidgetHostViewAndroid() {
   if (content_view_core_)
     content_view_core_->RemoveObserver(this);
   SetContentViewCore(NULL);
   if (ime_adapter_android_)
     ime_adapter_android_ = nullptr;

[boliu, 2017/04/13 04:29:41]

this should be redundant, this should be an DCHECK null

[Jinsuk Kim, 2017/04/13 04:44:05]

Done.

+  for (auto* observer : destruction_observers_)

[boliu, 2017/04/13 04:29:41]

this should be called from Destroy, not here, otherwise could lead to be calling
virtual methods from destructor

[Jinsuk Kim, 2017/04/13 04:44:05]

Done.

+    observer->RenderWidgetHostViewDestroyed(this);
   DCHECK(ack_callbacks_.empty());
   DCHECK(!delegated_frame_host_);
 }
 
 void RenderWidgetHostViewAndroid::Blur() {
   host_->Blur();
   if (overscroll_controller_)
     overscroll_controller_->Disable();
 }
 
+void RenderWidgetHostViewAndroid::AddDestructionObserver(
+    DestructionObserver* connector) {
+  destruction_observers_.push_back(connector);
+}
+
+void RenderWidgetHostViewAndroid::RemoveDestructionObserver(
+    DestructionObserver* connector) {
+  auto it = std::find(destruction_observers_.begin(),
+                      destruction_observers_.end(), connector);
+  DCHECK(it != destruction_observers_.end());
+  destruction_observers_.erase(it);
+}
+
 bool RenderWidgetHostViewAndroid::OnMessageReceived(
     const IPC::Message& message) {
   if (IPC_MESSAGE_ID_CLASS(message.type()) == SyncCompositorMsgStart) {
     return SyncCompositorOnMessageReceived(message);
   }
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(RenderWidgetHostViewAndroid, message)
     IPC_MESSAGE_HANDLER(ViewHostMsg_ShowUnhandledTapUIIfNeeded,
                         OnShowUnhandledTapUIIfNeeded)
     IPC_MESSAGE_UNHANDLED(handled = false)
@@ skipping 1658 matching lines @@
 
   ui::WindowAndroidCompositor* compositor = window_android->GetCompositor();
   if (!compositor)
     return;
 
   overscroll_controller_ = base::MakeUnique<OverscrollControllerAndroid>(
       overscroll_refresh_handler, compositor, view_.GetDipScale());
 }
 
 }  // namespace content