Factor out RenderWidgetHostConnector

content/browser/android/ime_adapter_android.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_ANDROID_IME_ADAPTER_ANDROID_H_
 #define CONTENT_BROWSER_ANDROID_IME_ADAPTER_ANDROID_H_
 
 #include <jni.h>
 
 #include <vector>
 
 #include "base/android/jni_weak_ref.h"
-#include "base/memory/weak_ptr.h"
+#include "content/browser/android/render_widget_host_connector.h"
 #include "content/common/content_export.h"
-#include "content/public/browser/web_contents_observer.h"
 #include "ui/gfx/geometry/rect_f.h"
 
 namespace blink {
 
 struct WebCompositionUnderline;
 
 }  // namespace blink
 
 namespace content {
 
 class RenderFrameHost;
 class RenderWidgetHostImpl;
 class RenderWidgetHostViewAndroid;
 struct TextInputState;
 
 // This class is in charge of dispatching key events from the java side
 // and forward to renderer along with input method results via
 // corresponding host view.
-// Ownership of these objects remains on the native side (see
-// RenderWidgetHostViewAndroid).
-class CONTENT_EXPORT ImeAdapterAndroid : public WebContentsObserver {
+class CONTENT_EXPORT ImeAdapterAndroid : public RenderWidgetHostConnector {
  public:
   ImeAdapterAndroid(JNIEnv* env,
                     const base::android::JavaParamRef<jobject>& obj,
                     WebContents* web_contents);
   ~ImeAdapterAndroid() override;
 
   // Called from java -> native
   bool SendKeyEvent(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>&,
@@ skipping 34 matching lines @@
       const base::android::JavaParamRef<jobject>&,
       int before,
       int after);
   void RequestCursorUpdate(JNIEnv*,
                            const base::android::JavaParamRef<jobject>&,
                            bool immediateRequest,
                            bool monitorRequest);
   bool RequestTextInputStateUpdate(JNIEnv*,
                                    const base::android::JavaParamRef<jobject>&);
 
+  // RendetWidgetHostConnector implementation.
+  void UpdateRenderProcessConnection(
+      RenderWidgetHostViewAndroid* old_rwhva,
+      RenderWidgetHostViewAndroid* new_rhwva) override;
+
   // Called from native -> java
   void CancelComposition();
   void FocusedNodeChanged(bool is_editable_node);
   void SetCharacterBounds(const std::vector<gfx::RectF>& rects);
 
   base::android::ScopedJavaLocalRef<jobject> java_ime_adapter_for_testing(
       JNIEnv* env) {
     return java_ime_adapter_.get(env);
   }
 
-  // WebContentsObserver implementation.
-  void RenderViewReady() override;
-  void RenderViewHostChanged(RenderViewHost* old_host,
-                             RenderViewHost* new_host) override;
-  void DidAttachInterstitialPage() override;
-  void DidDetachInterstitialPage() override;
-  void WebContentsDestroyed() override;
-
   void UpdateState(const TextInputState& state);
 
  private:
   RenderWidgetHostImpl* GetFocusedWidget();
   RenderFrameHost* GetFocusedFrame();
   std::vector<blink::WebCompositionUnderline> GetUnderlinesFromSpans(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj,
       const base::android::JavaParamRef<jobject>& text,
       const base::string16& text16);
-  RenderWidgetHostViewAndroid* GetRenderWidgetHostViewAndroid() const;
-  void UpdateRenderProcessConnection(RenderWidgetHostViewAndroid* new_rwhva);
 
-  base::WeakPtr<RenderWidgetHostViewAndroid> rwhva_;
+  // Flag used to notify Java layer of the render process connection
+  // at the beginning.
+  bool connected_;

[boliu, 2017/04/10 18:08:43]

java side already has this state, no need to repeat it here

[Jinsuk Kim, 2017/04/11 01:41:58]

Done. Replacing it with (!old_rwhva && new_rwhva) to call Java layer will work
too.

   JavaObjectWeakGlobalRef java_ime_adapter_;
 };
 
 bool RegisterImeAdapter(JNIEnv* env);
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_ANDROID_IME_ADAPTER_ANDROID_H_