Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2086)

Unified Diff: pkg/front_end/test/scanner_fasta_test.dart

Issue 2792053002: Scan generic method comments with Fasta. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/src/scanner/token.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/test/scanner_fasta_test.dart
diff --git a/pkg/front_end/test/scanner_fasta_test.dart b/pkg/front_end/test/scanner_fasta_test.dart
index 2bb559aaa212099c74256eaf47749f5e0a017128..ee1d36af75d35984cb46a4ede4b215ad84245188 100644
--- a/pkg/front_end/test/scanner_fasta_test.dart
+++ b/pkg/front_end/test/scanner_fasta_test.dart
@@ -29,17 +29,12 @@ class ScannerTest_Fasta extends ScannerTestBase {
Token scanWithListener(String source, ErrorListener listener,
{bool genericMethodComments: false,
bool lazyAssignmentOperators: false}) {
- if (genericMethodComments) {
- // Fasta doesn't support generic method comments.
- // TODO(paulberry): once the analyzer toolchain no longer needs generic
- // method comments, remove tests that exercise them.
- fail('No generic method comment support in Fasta');
- }
// Note: Fasta always supports lazy assignment operators (`&&=` and `||=`),
// so we can ignore the `lazyAssignmentOperators` flag.
// TODO(paulberry): once lazyAssignmentOperators are fully supported by
// Dart, remove this flag.
var scanner = new fasta.StringScanner(source, includeComments: true);
+ scanner.scanGenericMethodComments = genericMethodComments;
var token = scanner.tokenize();
return new ToAnalyzerTokenStreamConverter_WithListener(listener)
.convertTokens(token);
@@ -143,20 +138,6 @@ class ScannerTest_Fasta extends ScannerTestBase {
@override
@failingTest
- void test_comment_generic_method_type_assign() {
- // TODO(paulberry,ahe): Fasta doesn't support generic method comment syntax.
- super.test_comment_generic_method_type_assign();
- }
-
- @override
- @failingTest
- void test_comment_generic_method_type_list() {
- // TODO(paulberry,ahe): Fasta doesn't support generic method comment syntax.
- super.test_comment_generic_method_type_list();
- }
-
- @override
- @failingTest
void test_mismatched_closer() {
// TODO(paulberry,ahe): Fasta and analyzer recover this error differently.
// Figure out which recovery technique we want the front end to use.
« no previous file with comments | « pkg/front_end/lib/src/scanner/token.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698