Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2792033002: [kernel] vm: Fix a few issues in the kernel flow graph builder, update status file for checked-mode (Closed)

Created:
3 years, 8 months ago by kustermann
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[kernel] vm: Fix a few issues in the kernel flow graph builder, update status file for checked-mode R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/d8e291cb89a3e777dea33234108fa42fd504d4b9

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -56 lines) Patch
M pkg/kernel/lib/transformations/continuation.dart View 4 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/compiler.cc View 1 3 chunks +25 lines, -29 lines 0 comments Download
M runtime/vm/kernel_to_il.cc View 1 2 chunks +16 lines, -13 lines 0 comments Download
M tests/co19/co19-kernel.status View 4 chunks +33 lines, -8 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +23 lines, -0 lines 0 comments Download
M tests/language/language_kernel.status View 3 chunks +70 lines, -2 lines 0 comments Download
M tests/lib/lib.status View 3 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kustermann
3 years, 8 months ago (2017-04-03 15:40:36 UTC) #2
Vyacheslav Egorov (Google)
lgtm https://codereview.chromium.org/2792033002/diff/1/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/2792033002/diff/1/runtime/vm/compiler.cc#newcode1722 runtime/vm/compiler.cc:1722: const Code& code = Code::Handle(helper.Compile(&pipeline)); Maybe fix Compiler::ExecuteOnce(...) ...
3 years, 8 months ago (2017-04-03 17:05:19 UTC) #3
kustermann
https://codereview.chromium.org/2792033002/diff/1/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/2792033002/diff/1/runtime/vm/compiler.cc#newcode1722 runtime/vm/compiler.cc:1722: const Code& code = Code::Handle(helper.Compile(&pipeline)); On 2017/04/03 17:05:19, Vyacheslav ...
3 years, 8 months ago (2017-04-03 17:35:18 UTC) #4
kustermann
3 years, 8 months ago (2017-04-03 17:47:13 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d8e291cb89a3e777dea33234108fa42fd504d4b9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698