Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)
Patch Set: Remove unused method. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart
diff --git a/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart b/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart
index 9d08775595542824d67d29cdccb646a687f6b24c..866dabddc60c16475265f04ff9c330a5010a728f 100644
--- a/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart
+++ b/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart
@@ -20,7 +20,6 @@ import '../js/js.dart' as js;
import '../js_backend/js_backend.dart';
import '../kernel/element_adapter.dart';
import '../kernel/kernel.dart';
-import '../kernel/kernel_debug.dart';
import '../native/native.dart' as native;
import '../resolution/tree_elements.dart';
import '../tree/tree.dart' as ast;
@@ -376,9 +375,8 @@ class KernelAstAdapter extends KernelElementAdapterMixin {
KernelJumpTarget getJumpTarget(ir.TreeNode node,
{bool isContinueTarget: false}) {
return _jumpTargets.putIfAbsent(node, () {
- if (node is ir.LabeledStatement &&
- _jumpTargets.containsKey((node as ir.LabeledStatement).body)) {
- return _jumpTargets[(node as ir.LabeledStatement).body];
+ if (node is ir.LabeledStatement && _jumpTargets.containsKey(node.body)) {
+ return _jumpTargets[node.body];
}
return new KernelJumpTarget(node, this,
makeContinueLabel: isContinueTarget);
@@ -426,7 +424,8 @@ class KernelAstAdapter extends KernelElementAdapterMixin {
TypeMask get streamIteratorConstructorType =>
TypeMaskFactory.inferredReturnTypeForElement(
- _backend.helpers.streamIteratorConstructor as FunctionEntity,
+ // ignore: ARGUMENT_TYPE_NOT_ASSIGNABLE
+ _backend.helpers.streamIteratorConstructor,
Johnni Winther 2017/04/03 12:07:33 Reinsert the cast and ignore the hint.
ahe 2017/04/03 12:25:07 Done.
_globalInferenceResults);
ir.Procedure get fallThroughError =>
@@ -613,11 +612,6 @@ class KernelAstAdapter extends KernelElementAdapterMixin {
getClass(cls), getDartTypes(typeArguments));
}
- @override
- InterfaceType getThisType(ir.Class cls) {
- return getClass(cls).thisType;
- }
-
MemberEntity getConstructorBodyEntity(ir.Constructor constructor) {
AstElement element = getElement(constructor);
MemberEntity constructorBody =

Powered by Google App Engine
This is Rietveld 408576698