Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: chromeos/dbus/upstart_client.h

Issue 2791983004: DBus MediaAnalyticsClient and media_perception pb. (Closed)
Patch Set: Addressing comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMEOS_DBUS_UPSTART_CLIENT_H_ 5 #ifndef CHROMEOS_DBUS_UPSTART_CLIENT_H_
6 #define CHROMEOS_DBUS_UPSTART_CLIENT_H_ 6 #define CHROMEOS_DBUS_UPSTART_CLIENT_H_
7 7
8 #include "base/callback.h"
9 #include "base/macros.h"
8 #include "chromeos/chromeos_export.h" 10 #include "chromeos/chromeos_export.h"
9 #include "chromeos/dbus/dbus_client.h" 11 #include "chromeos/dbus/dbus_client.h"
10 12
11 namespace chromeos { 13 namespace chromeos {
12 14
13 // UpstartClient is used to communicate with the com.ubuntu.Upstart 15 // UpstartClient is used to communicate with the com.ubuntu.Upstart
14 // sevice. All methods should be called from the origin thread (UI thread) which 16 // sevice. All methods should be called from the origin thread (UI thread) which
15 // initializes the DBusThreadManager instance. 17 // initializes the DBusThreadManager instance.
16 class CHROMEOS_EXPORT UpstartClient : public DBusClient { 18 class CHROMEOS_EXPORT UpstartClient : public DBusClient {
17 public: 19 public:
18 ~UpstartClient() override; 20 ~UpstartClient() override;
19 21
22 using UpstartCallback = base::Callback<void(bool succeeded)>;
20 // Factory function, creates a new instance and returns ownership. 23 // Factory function, creates a new instance and returns ownership.
21 // For normal usage, access the singleton via DBusThreadManager::Get(). 24 // For normal usage, access the singleton via DBusThreadManager::Get().
22 static UpstartClient* Create(); 25 static UpstartClient* Create();
23 26
24 // Starts authpolicyd. 27 // Starts authpolicyd.
25 virtual void StartAuthPolicyService() = 0; 28 virtual void StartAuthPolicyService() = 0;
26 29
27 // Restarts authpolicyd. 30 // Restarts authpolicyd.
28 virtual void RestartAuthPolicyService() = 0; 31 virtual void RestartAuthPolicyService() = 0;
29 32
33 // Process management of a separate media analytics process.
tbarzic 2017/05/11 16:55:55 Comment each of the methods: Starts media analyti
Luke Sorenson 2017/05/11 18:16:48 Done.
34 virtual void StartMediaAnalytics(const UpstartCallback& callback) = 0;
35 virtual void StopMediaAnalytics() = 0;
36
30 protected: 37 protected:
31 // Create() should be used instead. 38 // Create() should be used instead.
32 UpstartClient(); 39 UpstartClient();
33 40
34 private: 41 private:
35 DISALLOW_COPY_AND_ASSIGN(UpstartClient); 42 DISALLOW_COPY_AND_ASSIGN(UpstartClient);
36 }; 43 };
37 44
38 } // namespace chromeos 45 } // namespace chromeos
39 46
40 #endif // CHROMEOS_DBUS_UPSTART_CLIENT_H_ 47 #endif // CHROMEOS_DBUS_UPSTART_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698