Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issue 2791983002: Revert "When linking natives lazily (as in AOT compilation), don't resolve them eagerly." (Closed)

Created:
3 years, 8 months ago by Vyacheslav Egorov (Google)
Modified:
3 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "When linking natives lazily (as in AOT compilation), don't resolve them eagerly." This reverts commit 8df8025f2acb09c55e8c22ba22826f03cbf497cb. Reason: darkp configuration is completely broken by this CL. Example: $ python tools/test.py -mrelease -cdartkp -rdart_precompiled -t120 kernel/unsorted/symbol_literal_test TBR=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/7f147b1b6e62ff09dc77d5539aa2601c493d6279

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M runtime/vm/intermediate_language.cc View 2 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Vyacheslav Egorov (Google)
3 years, 8 months ago (2017-04-03 09:41:07 UTC) #1
Vyacheslav Egorov (Google)
Committed patchset #1 (id:1) manually as 7f147b1b6e62ff09dc77d5539aa2601c493d6279 (presubmit successful).
3 years, 8 months ago (2017-04-03 10:02:39 UTC) #3
rmacnak
3 years, 8 months ago (2017-04-03 16:05:21 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698