Chromium Code Reviews| Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/PhoneNumberUtil.java |
| diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/PhoneNumberUtil.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/PhoneNumberUtil.java |
| index 2315304acbccca0cfad5f8fead07f7746bc5856f..9a437e745d08400d1e1d3ebcb56476d80090b0de 100644 |
| --- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/PhoneNumberUtil.java |
| +++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/PhoneNumberUtil.java |
| @@ -27,7 +27,7 @@ public class PhoneNumberUtil { |
| public void afterTextChanged(Editable s) { |
| if (mSelfChange) return; |
| - String formattedNumber = format(s.toString()); |
| + String formattedNumber = formatForDisplay(s.toString()); |
| mSelfChange = true; |
| s.replace(0, s.length(), formattedNumber, 0, formattedNumber.length()); |
| mSelfChange = false; |
| @@ -49,8 +49,21 @@ public class PhoneNumberUtil { |
| * @param phoneNumber The given phone number. |
| * @return formatted phone number. |
|
please use gerrit instead
2017/04/04 18:28:22
Capital F.
sebsg
2017/04/04 19:55:57
Done.
|
| */ |
| - public static String format(String phoneNumber) { |
| - return nativeFormat(phoneNumber); |
| + public static String formatForDisplay(String phoneNumber) { |
| + return nativeFormatForDisplay(phoneNumber); |
| + } |
| + |
| + /** |
| + * Formats the given phone number in E.164 format |
|
please use gerrit instead
2017/04/04 18:28:22
Link to spec section that mentions E.164.
sebsg
2017/04/04 19:55:57
Done.
|
| + * [i18n::phonenumbers::PhoneNumberUtil::PhoneNumberFormat::E164], returning the original number |
| + * if no formatting can be made. For example, the number of the Google Zürich office will be |
| + * formatted as "+41446681800" in E.164 format. |
| + * |
| + * @param phoneNumber The given phone number. |
| + * @return formatted phone number. |
|
please use gerrit instead
2017/04/04 18:28:22
Capital F.
sebsg
2017/04/04 19:55:57
Done.
|
| + */ |
| + public static String formatForResponse(String phoneNumber) { |
| + return nativeFormatForResponse(phoneNumber); |
| } |
| /** |
| @@ -65,6 +78,7 @@ public class PhoneNumberUtil { |
| return nativeIsValidNumber(phoneNumber); |
| } |
| - private static native String nativeFormat(String phoneNumber); |
| + private static native String nativeFormatForDisplay(String phoneNumber); |
| + private static native String nativeFormatForResponse(String phoneNumber); |
| private static native boolean nativeIsValidNumber(String phoneNumber); |
| } |