Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 2791963002: Merge to M58: Resolve preloadResponse of Navigation Preload even if the response body is empty. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index babd858683d03a2c59cc7499b4e784554a2dbe72..93873a0ea51e4e7b8231cda2ad62f9a45f82277a 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -276,8 +276,7 @@ class ServiceWorkerContextClient::NavigationPreloadRequest final
url_loader_(std::move(preload_handle->url_loader)),
binding_(this, std::move(preload_handle->url_loader_client_request)) {}
- ~NavigationPreloadRequest() override {
- }
+ ~NavigationPreloadRequest() override {}
void OnReceiveResponse(
const ResourceResponseHead& response_head,
@@ -333,6 +332,13 @@ class ServiceWorkerContextClient::NavigationPreloadRequest final
ServiceWorkerContextClient::ThreadSpecificInstance();
if (!client)
return;
+ if (response_) {
+ // When the response body from the server is empty, OnComplete() is called
+ // without OnStartLoadingResponseBody().
+ DCHECK(!body_.is_valid());
+ client->OnNavigationPreloadResponse(fetch_event_id_, std::move(response_),
+ nullptr);
+ }
// This will delete |this|.
client->OnNavigationPreloadComplete(fetch_event_id_);
}
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-preload/empty-preload-response-body.https.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698