setMayNeedPaintInvalidation in setNeedsOverflowRecalcAfterStyleChange()

third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

Index: third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp b/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
index b208df2e9058015007e597387b0e3d6d2f944ccf..9c9874dc5cf384a764af35be91348bf67018547d 100644
--- a/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
@@ -487,7 +487,8 @@ void PaintInvalidator::invalidatePaintIfNeeded(
         PaintInvalidatorContext::ForcedSubtreeInvalidationChecking;
   }
 
-  if (context.oldLocation != context.newLocation) {
+  if (context.oldLocation != context.newLocation &&
+      !context.paintingLayer->subtreeIsInvisible()) {

[chrishtr, 2017/04/04 17:03:45]

Could you add a test checking that making the tree visible again
will correctly update all these things?

Also, what is the mechanism that does that, especially after
https://codereview.chromium.org/2792063002/?

[Xianzhu, 2017/04/04 18:03:33]

Done.
The mechanism ensuring correct paint invalidation is existing:
- visibility change will cause full paint invalidation through style change
paint invalidation;
- subtreeIsInvisible flag is updated in
PaintLayer::updateDescendantDependentFlags().

     context.forcedSubtreeInvalidationFlags |=
         PaintInvalidatorContext::ForcedSubtreeInvalidationChecking;
   }