Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3747)

Unified Diff: chrome/browser/installable/installable_logging.cc

Issue 2791923005: Fails InstallableManager if a selected badge icon cannot be fetched. (Closed)
Patch Set: Addressing comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/installable/installable_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/installable/installable_logging.cc
diff --git a/chrome/browser/installable/installable_logging.cc b/chrome/browser/installable/installable_logging.cc
index 926dd2a3d6beadadfe3fbd6c43e79086faa210f4..b7cf0e2b76f3f0d6e4af98af3ea0162b312cc841 100644
--- a/chrome/browser/installable/installable_logging.cc
+++ b/chrome/browser/installable/installable_logging.cc
@@ -50,9 +50,9 @@ static const char kNoAcceptableIconMessage[] =
"a %spx square icon is required, but no supplied icon meets this "
"requirement";
static const char kCannotDownloadIconMessage[] =
- "could not download the specified icon";
+ "could not download a required icon from manifest";
dominickn 2017/04/07 00:02:34 Nit: "the manifest"
F 2017/04/07 14:43:11 Done.
static const char kNoIconAvailableMessage[] =
- "no icon available to display";
+ "icon downloaded from the manifest was empty or corrupted";
static const char kPlatformNotSupportedOnAndroidMessage[] =
"the specified application platform is not supported on Android";
static const char kNoIdSpecifiedMessage[] =
« no previous file with comments | « no previous file | chrome/browser/installable/installable_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698