chrome/browser/installable/installable_manager.h - Issue 2791923005: Fails InstallableManager if a selected badge icon cannot be fetched.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/installable/installable_manager.h

Issue 2791923005: Fails InstallableManager if a selected badge icon cannot be fetched. (Closed)

Patch Set: Correct the error of making badge icon required Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/installable/installable_manager.h

diff --git a/chrome/browser/installable/installable_manager.h b/chrome/browser/installable/installable_manager.h

index 5d56abd0e35b2c22e0a9c43bcf3e4b70d394e9b1..87171a2c9a49d7c0813e3c92e6a10436dee71e43 100644

--- a/chrome/browser/installable/installable_manager.h

+++ b/chrome/browser/installable/installable_manager.h

@@ -198,7 +198,7 @@ class InstallableManager

void CheckServiceWorker();

void OnDidCheckHasServiceWorker(content::ServiceWorkerCapability capability);

- void CheckAndFetchBestIcon(const IconParams& params);

+ void CheckAndFetchBestIcon(const IconParams& params, bool is_required);

void OnIconFetched(

const GURL icon_url, const IconParams& params, const SkBitmap& bitmap);